fix: resolve docker CLI outside the inherited PATH#131
Merged
Conversation
App-managed mode ran `docker` by bare name, which fails on GUI (Finder/launchd) launches that get a minimal PATH without /usr/local/bin etc. Resolve the binary from known install locations (SUPERCODER_DOCKER_BIN overrides) and widen the child PATH. Adds regression tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
App-managed mode invoked
dockerby bare name, which fails on GUI launches (Finder/launchd) that inherit a minimal PATH without/usr/local/bin,/opt/homebrew/bin, etc. — so the Context Engine couldn't start even with Docker installed.Resolves the
dockerbinary from known install locations (withSUPERCODER_DOCKER_BINas an override) and widens the child PATH. Adds regression tests covering the minimal-PATH case.