Skip to content

fix(ci): clippy #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Totodore merged 2 commits into from
Jul 22, 2026
Merged

fix(ci): clippy #765

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21dbd7a
fix(ci): clippy
Totodore Jul 22, 2026
a95eed6
fix(ci): clippy
Totodore Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 6 additions & 24 deletions .github/workflows/github-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,20 +136,13 @@ jobs:
key: ${{ runner.os }}-cargo-${{ hashFiles('examples/Cargo.lock') }}-examples
- run: cd examples && cargo check --all-features

rust-clippy-analyze:
clippy:
runs-on: ubuntu-latest
permissions:
contents: read
security-events: write
actions: read # only required for a private repository by github/codeql-action/upload-sarif to get the Action run status
steps:
- name: Checkout code
uses: actions/checkout@v7

- name: Install Rust toolchain
uses: dtolnay/rust-toolchain@master
- uses: actions/checkout@v7
- uses: dtolnay/rust-toolchain@master
with:
toolchain: 1.94.0
toolchain: 1.94.0 # TODO(bump): switch to new cargo deny warnings + continue on error
components: clippy
- uses: actions/cache@v6
with:
Expand All @@ -161,19 +154,8 @@ jobs:
target/
key: ${{ runner.os }}-cargo-${{ hashFiles('Cargo.lock') }}-clippy

- name: Install required cargo │
run: cargo install clippy-sarif sarif-fmt || true

- name: Run rust-clippy
run: cargo clippy --all-features --workspace --examples --tests --message-format=json -- -D warnings
| clippy-sarif | tee rust-clippy-results.sarif | sarif-fmt
continue-on-error: true

- name: Upload analysis results to GitHub
uses: github/codeql-action/upload-sarif@v4
with:
sarif_file: rust-clippy-results.sarif
wait-for-processing: true
run: cargo clippy --all-features --workspace --examples --tests -- -D warnings

engine_io:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -292,7 +274,7 @@ jobs:
runs-on: ubuntu-latest
if: always()
needs:
[adapter, feature_set, format, udeps, msrv, examples, rust-clippy-analyze]
[adapter, feature_set, format, udeps, msrv, examples, clippy]
steps:
- uses: re-actors/alls-green@release/v1
with:
Expand Down