Skip to content

bugfix - #22

Merged
TopSwagCode merged 8 commits into
masterfrom
bugfix/parameters
Jan 19, 2026
Merged

TopSwagCode merged 8 commits into
masterfrom
bugfix/parameters

Conversation

@TopSwagCode

Copy link
Copy Markdown
Owner

No description provided.

@codecov-commenter

codecov-commenter commented Jan 19, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.95%. Comparing base (fc17e14) to head (9778ec9).
⚠️ Report is 9 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #22   +/-   ##
=======================================
  Coverage   77.95%   77.95%           
=======================================
  Files           2        2           
  Lines         186      186           
  Branches       28       28           
=======================================
  Hits          145      145           
  Misses         21       21           
  Partials       20       20           
Flag Coverage Δ
unittests 77.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug in the source generator where generic type signatures with multiple type parameters were not matching correctly between compile-time and runtime. The issue occurred because Roslyn's SymbolDisplayFormat.FullyQualifiedFormat includes spaces after commas in generic type arguments (e.g., IConsumer<string, string>), while the runtime's FormatTypeName method produces signatures without spaces (e.g., IConsumer<string,string>). The fix normalizes the spacing by removing spaces after commas in the generated signatures.

Changes:

  • Fixed signature matching in WorkerEmitter.cs by normalizing generic type parameter spacing
  • Added comprehensive test coverage with two new test cases for multi-type generic parameters
  • Added test helper interfaces and implementations to support the new tests

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
src/MinimalWorker.Generators/WorkerEmitter.cs Fixed signature generation to strip spaces after commas in generic type arguments, ensuring alignment with runtime signature format
test/MinimalWorker.Test/Fakes/FakeRepositories.cs Added IConsumer and IMultipleConsumer interfaces with implementations to test multi-type generic parameter resolution
test/MinimalWorker.Test/ServiceResolutionTests.cs Added two test cases verifying that background workers can resolve services with multiple generic type arguments

Comment thread test/MinimalWorker.Test/Fakes/FakeRepositories.cs Outdated
Comment thread test/MinimalWorker.Test/ServiceResolutionTests.cs
Comment thread test/MinimalWorker.Test/ServiceResolutionTests.cs Outdated
Comment thread test/MinimalWorker.Test/ServiceResolutionTests.cs Outdated
Comment thread test/MinimalWorker.Test/ServiceResolutionTests.cs
TopSwagCode and others added 5 commits January 19, 2026 21:54
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@TopSwagCode
TopSwagCode merged commit 71c1b8e into master Jan 19, 2026
7 checks passed
@TopSwagCode
TopSwagCode deleted the bugfix/parameters branch January 19, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants