Skip to content

chore: restructure packages of the definition module - #2813

Merged
rsynek merged 11 commits into
TimefoldAI:mainfrom
rsynek:chore/definition-preview-api
Nov 16, 2026
Merged

rsynek merged 11 commits into
TimefoldAI:mainfrom
rsynek:chore/definition-preview-api

Conversation

@rsynek

@rsynek rsynek commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

@winklerm Introducing the new structure; the build fails due to Revapi, which is expected at this point.

I will make further changes only if the new structure is reviewed and accepted.

@rsynek
rsynek requested a review from winklerm November 9, 2026 16:34

@winklerm winklerm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, the structure looks very good to me!

Please see a few questions/comments inline.

@winklerm winklerm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good to me!

@rsynek rsynek changed the title Restructure packages of the definition module chore: restructure packages of the definition module Nov 12, 2026
@rsynek
rsynek force-pushed the chore/definition-preview-api branch from bbe074d to 15f10f2 Compare November 12, 2026 12:58
@rsynek
rsynek force-pushed the chore/definition-preview-api branch from b1a4266 to 27ae3c9 Compare November 13, 2026 11:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

@timefold-automations

timefold-automations Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

The docs drift this comment reported earlier is gone: the latest commits update the ModelConfigOverrides and ModelResponse package names and add an upgrade note for the service definition package restructuring.


Generated by Solver Docs Drift Review with Claude.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The automated review did not complete successfully.

No open issues 🎉

Review effort: Balanced

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

@rsynek
rsynek merged commit 139eff1 into TimefoldAI:main Nov 16, 2026
33 of 42 checks passed

This branch was successfully deployed

2 active deployments
documentation (preview) — 130eebfb Deployed Nov 16, 2026 by rsynek via Build Documentation #911
internal — 130eebfb Deployed Nov 16, 2026 by rsynek via approval_required #5340
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants