feat(cloud_server): implement SSL secure websocket from semver2 into semver3 - #723
Open
Boss-1s wants to merge 30 commits into
Open
feat(cloud_server): implement SSL secure websocket from semver2 into semver3#723Boss-1s wants to merge 30 commits into
Boss-1s wants to merge 30 commits into
Conversation
…semver3 Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
- Moved `BaseCloudServer` (Formerly `_SaCloudServer`) to sa.eventhandlers._base Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Contributor
Author
TheCommCraft
reviewed
Sep 2, 2026
Collaborator
|
Tell me if you require help in applying these changes |
(cherry picked from commit 8d30697) Signed-off-by: GitHub <noreply@github.com>
Boss-1s
force-pushed
the
semver3-secure-ws
branch
from
September 2, 2026 21:40
9a6846e to
2950297
Compare
### sa.eventhandlers._base - changed list comp to generator comp in set_project_vars() and set_var() - reimplemented attribute type hints into BaseCloudServer. since type hints are inhierted, there is no need to restate them in child classes of BaseCloudServer. ### sa.eventhandlers.cloud_server - added type hitns to __init__ of BaseCloudServer child classes - added type hints to init_cloud_server and init_ssl_cloud_server - revert changing warnings.warn to print in 9863d50 Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
TheCommCraft
requested changes
Sep 2, 2026
Co-authored-by: TheCommCraft <79996518+TheCommCraft@users.noreply.github.com> Signed-off-by: Boss_1s <95505913+Boss-1s@users.noreply.github.com>
Boss-1s
commented
Sep 3, 2026
| *, | ||
| user: str = "@server", | ||
| skip_forward=None, | ||
| skip_broadcast_for: WebSocket | None = None, |
Contributor
Author
There was a problem hiding this comment.
Should we add documentation or something of the sort for this argument?
Signed-off-by: Boss_1s <95505913+Boss-1s@users.noreply.github.com>
Boss-1s
commented
Sep 4, 2026
Collaborator
|
serveforever is implemented with a while loop of serveonce |
TheCommCraft
requested changes
Sep 4, 2026
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Collaborator
|
I think that the custom cloud solution you added might cause extreme lag, it would be better to just not add a cloud at first (or you could create a cloud that just translates method calls of the cloud into those of the server) |
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: GitHub <noreply@github.com>
This comment was marked as resolved.
This comment was marked as resolved.
TheCommCraft
had a problem deploying
to
release
September 7, 2026 15:02 — with
GitHub Actions
Failure
TheCommCraft
had a problem deploying
to
release
September 7, 2026 15:21 — with
GitHub Actions
Failure
Contributor
Author
|
The only thing left is the set var prefix option, then we should be done here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves nothing
Changes
Implemented SSL secure ws server (fix cloud server #658) from semver2 into semver 3
New class
_SaWebSockectServerBaseWebSocketServerinsa.eventhandlers._baseto keep things pythonic and organizedYou can now link a cloud
refactoring everything related cause why not
Tasks
Tests
First, start up an insecure server to ensure it works:
While the above script is running, run
websocat ws://127.0.0.1:8080to interact with the websocket.Once you have determined that this works, replace the above script with the one below:
Then, generate an OpenSSL certificate:
Finally, run the server script, and interact with the WebSocket with
websocat -k wss://127.0.0.1:8080Notes
might wanna have #722 fixed before merging this, idk