chore(cua): upgrade driver to v0.19.2 - #2127
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe CUA driver and installer requirements move to version 0.19.2. Packaging now creates runtime integrity descriptors with atomic replacement. Build signing results flow into descriptor generation, and tests cover the updated metadata and descriptor behavior. ChangesCUA runtime version upgrade
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant buildCuaPluginRuntime
participant packagePlugin
participant RuntimeDirectory
buildCuaPluginRuntime->>packagePlugin: provide target and signing purpose
packagePlugin->>RuntimeDirectory: read staged runtime files
packagePlugin->>RuntimeDirectory: atomically write integrity.json
packagePlugin-->>buildCuaPluginRuntime: return descriptor path
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/package-plugin.mjs`:
- Around line 683-694: Update the Windows replacement flow around the descriptor
rename to move the existing descriptor to a backup, attempt the replacement, and
restore the backup if that replacement fails; only remove the backup after
success, while retaining cleanup of temporary files. Add a regression test for
the packaging function that makes the second renameSync call fail and verifies
the original integrity.json is restored.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: baaf3337-b72e-4bb6-b5ad-2e8bf16c55ad
📒 Files selected for processing (9)
plugins/cua/plugin.jsonplugins/cua/vendor/cua-driver/upstream.jsonscripts/build-cua-plugin-runtime.mjsscripts/package-plugin.mjssrc/main/plugin/cuaToolAdapter.tstest/main/plugin/cuaEmbeddedAdapter.test.tstest/main/plugin/pluginService.test.tstest/main/scripts/buildCuaPluginRuntime.test.tstest/main/scripts/packagePlugin.test.ts
Summary
0.17.0to0.19.2.integrity.jsonduring local CUA runtime builds so the workspace plugin can be used withpnpm run dev.Compatibility assessment
Compared the real
0.17.0and0.19.2MCP documentation output:54.The embedded integration contract remains unchanged:
0.6.02025-06-1811Linux arm64 remains intentionally unsupported; this PR does not expand the existing platform matrix.
Development runtime fix
Previously,
pnpm plugin:cua:build:*generated the driver and tool catalog but not the integrity descriptor required when DeepChat loads the workspace plugin in development.The build now:
The descriptor:
Validation
cua-driver 0.19.25/5runtime file hashes match the generated descriptorcodesign --verify --deep --strictpnpm run devstartup without CUA integrity orintegrity.jsonerrors.dcpluginpackage descriptor verificationpnpm run format:checkpnpm run i18npnpm run lintpnpm run typecheckSummary by CodeRabbit
Updates
Bug Fixes