Fix jira-release-sync release-body handling#4
Merged
jonathangreen merged 1 commit intomainfrom Apr 30, 2026
Merged
Conversation
The action was reading the release body from github.event.release.body, ignoring the release-body input. Switch to the input, and add a release-body-file fallback so callers without a published-release context can still provide the body via a file path.
2 tasks
jonathangreen
added a commit
that referenced
this pull request
May 1, 2026
## Description Adds an end-to-end test workflow for the `jira-release-sync` action that runs on every PR touching `jira-release-sync/**`. The workflow: - Starts a small Python `mock_jira.py` HTTP server that implements just enough of the Jira REST API surface used by `action.yml` (create version, list versions, link related work, update issue fixVersions) and records every request to a JSONL log. - Runs the action against the mock server. - Asserts via `assert_calls.py` that the recorded requests match a per-case expectations JSON file. Two matrix cases are exercised: - `with_keys` — release body contains `PP-*` references (including a duplicate and a different-project key that must be ignored), expecting fixVersions updates. - `no_keys` — release body has no ticket references, expecting only the version + related-work calls. ## Motivation and Context The `jira-release-sync` action had no automated coverage, so regressions like the recent `release-body` handling fix (#4) could only be caught manually. This gives us a reproducible safety net for future changes to the action. ## How Has This Been Tested? - Mock server + assert script run locally against the action. - The new workflow `test-jira-release-sync.yml` is the test plan — it will run on this PR. ## Checklist - [x] I have updated the documentation accordingly. - [x] All new and existing tests passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release-bodyinput instead ofgithub.event.release.body, which silently ignored the input and broke any caller invoking the action outside arelease: publishedtrigger.release-body-fileinput as a fallback used only whenrelease-bodyis empty; fail with a clear message if neither is provided.