fix: dismiss first-time Rewards welcome modal - #597
Merged
TheNetsky merged 1 commit intoSep 1, 2026
Merged
Conversation
The welcome modal shown on the first visit to /earn blocks section#dailyset from rendering, causing bootstrap() to abort with a false 'dashboard did not render' error. Dismiss it before the check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: When an account (or a fresh browser context) visits /earn for the first time, a full-screen "Welcome" modal is shown (e.g. "Welcome to Microsoft Rewards — Earn gift cards, sweepstakes entries, and more" with a "Get started" button). While this modal is open, the dashboard does not render section#dailyset , so bootstrap() aborts with a false Rewards dashboard did not render error and the whole login is treated as failed.
Fix: Before inspecting the DOM in bootstrap() , wait briefly for the modal and click its confirm button (targeted via slot="close" , locale-independent), then wait up to 15s for section#dailyset to render. No-op for accounts that don't see the modal.
Evidence: error diagnostics captured page.content() and a screenshot of the failing state — the page shows the logged-in dashboard (points balance rendered, RSC payload contains the account's dailyset offers) hidden behind the modal.See attached screenshot for details. Sorry I forgot to take the screenshot in English.