Fix: Resolved string bounding bug in UI (Fixes #1234)#7499
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7499 +/- ##
=========================================
Coverage 79.91% 79.91%
Complexity 7353 7353
=========================================
Files 811 811
Lines 23879 23879
Branches 4705 4705
=========================================
+ Hits 19082 19084 +2
+ Misses 4036 4035 -1
+ Partials 761 760 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Hi @Abhi13shek , thanks for the contribution! I reviewed the diff and have a few observations:
The PR title says "Fixes #1234", but issue #1234 ("Can I add convex hull algorithms, some missing graph algos and hashing?") is a 2020 feature request that was auto-closed as stale in 2021. It has no connection to the changes in this PR — no convex hull, graph algorithm, or hashing code is touched here. Could you confirm the correct issue number this PR is meant to address? This PR mixes two separate concerns: NQueens.java: replacing System.out.println with Logger.info Per the contributing guidelines, it's usually cleaner to split unrelated changes into separate PRs — this makes review and rollback easier if something needs to be reverted later. Codecov flags 4 missing lines in NQueens.java (63.6% patch coverage). It might be worth adding a test case that covers the logger branches (the "no solution found" and "arrangement found" paths) to close that gap. In NQueens.java, LOGGER.info("") (replacing the old blank System.out.println()) doesn't really add value — loggers print structured lines (timestamp/level), so an empty call just creates a noisy blank entry rather than visual spacing. Might be worth removing it. |
clang-format -i --style=file path/to/your/file.java