fixed verific check error#4216
Open
sfmth wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
Open
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the conditional check for the WITH_VERIFIC variable in build_openroad.sh to use an integer comparison. The reviewer recommends using [[...]] with string comparison and proper variable quoting to improve robustness and maintain consistency with other conditional checks in the script.
| fi | ||
| options="" | ||
| if [ -n "${WITH_VERIFIC}" ]; then | ||
| if [ ${WITH_VERIFIC} -eq 1 ]; then |
There was a problem hiding this comment.
For improved robustness, it's recommended to use [[...]] for tests, quote variables, and use string comparison for flags. This prevents potential issues like word splitting or errors if the variable is not a valid integer. Using [[...]] is also more consistent with other conditional checks in this script (e.g., on line 194).
Suggested change
| if [ ${WITH_VERIFIC} -eq 1 ]; then | |
| if [[ "${WITH_VERIFIC}" == "1" ]]; then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was getting this error:
The script was checking for WITH_VERIFIC as not a numeral value, while it is one. and it's working now.