Skip to content

Add support for setting --hyperlinks via the RICH_HYPERLINKS environment variable#61

Open
andelink wants to merge 2 commits into
Textualize:mainfrom
andelink:ka/rich-hyperlinks-envvar
Open

Add support for setting --hyperlinks via the RICH_HYPERLINKS environment variable#61
andelink wants to merge 2 commits into
Textualize:mainfrom
andelink:ka/rich-hyperlinks-envvar

Conversation

@andelink

@andelink andelink commented Jul 31, 2022

Copy link
Copy Markdown

Small commit to allow setting --hyperlinks via the RICH_HYPERLINKS environment variable, so users can export this in their shell rc file and always have hyperlinks enabled.

Kapture 2022-07-31 at 09 26 11

Corresponding issue:

@andelink

Copy link
Copy Markdown
Author

@willmcgugan here's the PR

@harkabeeparolus harkabeeparolus left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes and documentation look good to me!

I wouldn't personally submit a PR that bumps the version number, but other than that I see no problems. 😊

@andelink

Copy link
Copy Markdown
Author

Thanks @harkabeeparolus! Reason I bumped the version is to hopefully get a new release of the library, so I can install and begin using these changes 🙂

(Also, I don't have permissions to merge the changes since I don't have write access to the repo, so merging is in your hands.)

@andelink

Copy link
Copy Markdown
Author

@harkabeeparolus would a patch version update be more welcome?

- version = "1.8.0"
+ version = "1.8.1"

@harkabeeparolus

Copy link
Copy Markdown
Collaborator

@harkabeeparolus would a patch version update be more welcome?

I wouldn't know, I'm just a random pythonista on GitHub — I don't have any commit access either. 😊 I just don't think I'd personally make a PR with an included version bump. Unless it was specifically about assisting the maintainers with a new release. But maybe that's just me. 🤔

(I do believe minor version would be appropriate from a Semantic Versioning perspective, since patch versions are supposed to be bugfixes without new features.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants