Repository navigation
UPSTREAM-PEND: backport COMP for MSPM0/MSPM33 - #53
Merged
Aman-Lachhiramka-ti merged 12 commits intoOct 7, 2026
Merged
Aman-Lachhiramka-ti merged 12 commits into
Aman-Lachhiramka-ti merged 12 commits into
Conversation
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
github-actions
Bot
added
manifest
manifest-cmsis_6
manifest-hal_ti
DNM (manifest)
labels
natto1784
force-pushed
the
v4.4.0-ti/drivers/comparator
branch
from
September 28, 2026 13:07
6c61ad0 to
9603326
Compare
natto1784
changed the title
natto1784
force-pushed
the
v4.4.0-ti/drivers/comparator
branch
from
October 6, 2026 09:24
9603326 to
ceea21f
Compare
…odule commit b565824 upstream. Add bindings for COMP modules in mspm0 g and l series Signed-off-by: Alexpandi Muniyandi <alexpandi@linumiz.com>
…odule commit 17c20d7 upstream. Add driver supporting the comp module in TI MSPM0 G and L series with interrupt trigger and reference voltage support. Add a window comparator mode feature for mspm0 g series Signed-off-by: Alexpandi Muniyandi <alexpandi@linumiz.com>
commit bfab089 upstream. Add a support for COMP nodes for mspm0 g and l series. Signed-off-by: Alexpandi Muniyandi <alexpandi@linumiz.com>
…test commit b131044 upstream. Add board overlay for the TI LP-MSPM0G3507 to enable the comparator gpio_loopback test using COMP0 with VDDA DAC reference on the negative terminal. Signed-off-by: Alexpandi Muniyandi <alexpandi@linumiz.com>
…r M... PR: 118623 Several MSP peripherals require a small delay of 4 ULPCLK cycles after enabling their power. When sourced from MCLK, ULPCLK can be as low as CPUCLK / 4, making 16 CPUCLK cycles a safe value for this delay instead of the default 8 CPUCLK cycles. This value works fine for MSPM0, MSPM33 and AM13 SoCs. Signed-off-by: Amneesh Singh <amneesh@ti.com>
PR: 118623 Several MSP peripherals require a small delay after enabling their power. This is configured by CONFIG_MSPM0_PERIPH_STARTUP_DELAY. Since this number is too small, k_busy_wait seems overkill, so just do that amount of NOPs instead and inline them. Signed-off-by: Amneesh Singh <amneesh@ti.com>
… ac... PR: 118623 Replace the ti/driverlib dl_comp.h dependency with a native register map so the driver no longer depends on the vendor HAL. All the behaviors and functionalities are unchanged. Signed-off-by: Amneesh Singh <amneesh@ti.com>
…on ... PR: 118623 MSPM33's COMP peripheral extends the shared register map with analog comparison wakeup control. These implement a wakeup sequencer for when device is in STOP mode while cycling between 4 voltage monitor and 4 thresholds (DAC reference codes). There is also a fixed "window mode" where you can statically fix the voltage monitor. Implement this functionality and guard the code with Kconfig that only gets enabled when using MSPM33. Signed-off-by: Amneesh Singh <amneesh@ti.com>
…ope... PR: 118623 Add ti,analog-comparison-dac-codes, ti,analog-comparison-cmpprd, ti,analog-comparison-blkprd and ti,analog-comparison-window-input to ti,mspm0-comparator.yaml, mirroring the analog comparison wakeup sequencer registers added to the driver. Signed-off-by: Amneesh Singh <amneesh@ti.com>
…eup... PR: 118623 Add CONFIG_COMPARATOR_MSPM0_ANALOG_COMPARISON, auto-enabled for SOC_SERIES_MSPM33C, gating the analog comparison wakeup sequencer support. Signed-off-by: Amneesh Singh <amneesh@ti.com>
PR: 118623 Add the two comparator instances available for MSPM33C SoCs. Signed-off-by: Amneesh Singh <amneesh@ti.com>
natto1784
force-pushed
the
v4.4.0-ti/drivers/comparator
branch
from
October 7, 2026 08:25
ceea21f to
eed7d85
Compare
github-actions
Bot
removed
manifest
manifest-hal_ti
manifest-cmsis_6
DNM (manifest)
labels
natto1784
force-pushed
the
v4.4.0-ti/drivers/comparator
branch
from
October 7, 2026 08:33
eed7d85 to
0bc193c
Compare
…oards PR: 118623 Add lp_mspm0g3519 and lp_mspm0l2228 overlays for the gpio_loopback comparator test, using internal DAC with VDD (3.3V) as negative reference and GPIO toggle on the positive channel. Signed-off-by: Amneesh Singh <amneesh@ti.com>
natto1784
force-pushed
the
v4.4.0-ti/drivers/comparator
branch
from
October 7, 2026 08:36
0bc193c to
df27d64
Compare
Aman-Lachhiramka-ti
approved these changes
Oct 7, 2026
Aman-Lachhiramka-ti
merged commit Oct 7, 2026
ba7cbdf
into
TexasInstruments:v4.4.0-ti-next
7 of 8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has following patchsets from upstream
This also has following patchsets from downstream baked in for support