Repository navigation
feat: keep a personal model catalog for Codex, Claude Code, and agent CLIs - #177
crispinhu27 wants to merge 3 commits into
Conversation
|
LoopForge PR Review — head Verdict: ✅ Pass
|
Official Codex, Claude Code, and Gemini keys can save their own model list, and the built-in catalogs now include GPT-6.1 Terra and Claude Haiku 5.5. Co-authored-by: Cursor <cursoragent@cursor.com>
Robert0622
left a comment
There was a problem hiding this comment.
Reviewed head 72fd087. No blocking findings in catalog persistence, omitted-versus-empty updates, official/custom endpoint selection, model ordering/names, and credential-editor changes.
Validation performed in this review: targeted repo credential round-trip, HTTP API assistant-engine catalog, and web credential tests passed; node --check web/app/workbench.js and node --test webtest/tests/workbench-credentials.test.mjs passed; relevant Go vet and public-content checks passed. A real CodeBuddy iOA scheduled chat turn on this head returned the expected marker, and the persisted transcript plus completed generation were verified using an isolated local fixture and the explicitly supplied credential. This confirms the CodeBuddy path remains functional; live calls to other CLI providers were not performed. No test credential is included in this review or source changes.
What changed
Personal settings can keep a model catalog for Codex, Claude Code, and the agent CLIs that use a custom Base URL: OpenCode, Antigravity, Kimi, Pi, DeepSeek Harness, and ZCode. From that page you can fetch the models a service publishes, then pick, reorder, and rename them. An empty catalog follows that published list. With no Base URL, or with the Gemini official protocol, the CLI's own models are used and the editor stays hidden. Cursor CLI still uses only its official models.
Codex and Claude Code catalogs are stored in new user_configs columns. Agent CLI catalogs stay in the existing credentials JSON. Startup AutoMigrate adds the columns; migrations/027_cli_model_catalog.sql is the same change for a manual apply.
Scope
Compatibility
Existing keys, Base URLs, and protocols are unchanged. A missing catalog follows the service list, which is the previous behavior. The new columns are nullable and additive. Cursor CLI is unchanged.
Validation
Ran:
Not run:
go test -p=2 ./...,go vet ./...,bash local/scripts/validate.sh,bash local/scripts/smoke-install.sh,bash local/scripts/e2e.sh,bash scripts/scan-secrets.sh.Safety
No Classic host bundles or third-party content changed.