Repository navigation
fix(web): publish a workflow only after its saved content changes - #168
crispinhu27 wants to merge 2 commits into
Conversation
|
LoopForge PR Review — head Verdict:
Missing to resolve: open the @crispinhu27 could you check that govulncheck log and confirm whether it's related to this change? |
Robert0622
left a comment
There was a problem hiding this comment.
Reviewed head ac626d2. No blocking findings in the workflow publication, revision-marker, legacy-definition compatibility, and editor changes.
Validation performed in this review: targeted repo/HTTP API workflow publication, revision and optimistic-locking tests passed; node --test webtest/tests/flows-editor.test.mjs webtest/tests/app-common.test.mjs passed; go vet ./internal/repo ./internal/httpapi and the public-content check passed. Also ran TestMySQLConcurrentWorkflowPublish against a disposable MySQL 8.4 container: concurrent publication of both project and generic workflows passed without duplicate version increments. The container was removed afterwards. No paid model call is needed for these deterministic publication changes.
What changed
Saving a workflow that has not changed no longer creates a revision, and publishing the same saved content keeps the current version. The publish button stays disabled while a publish is in flight and after the current content is already published.
Scope
Compatibility
No schema migration is required. Published workflows that predate the published-revision marker stay published until their saved content changes. Repeating a publish of unchanged content keeps the current version, and a client cannot mark an edit as already published.
Validation
Ran:
Not run:
go test -p=2 ./...,go vet ./...,bash local/scripts/validate.sh,bash local/scripts/smoke-install.sh,bash local/scripts/e2e.sh,bash scripts/scan-secrets.sh.Safety