Conversation
🎩 PreviewA preview build has been created at: |
This was referenced Sep 18, 2026
Draft
Collaborator
Author
camielvs
force-pushed
the
09-18-feat_open_a_project_in_tangent
branch
from
September 18, 2026 22:36
abacab5 to
b4fc1c9
Compare
camielvs
marked this pull request as draft
September 18, 2026 22:42
This was referenced Sep 18, 2026
This was referenced Sep 22, 2026
Clicking a project tile went to the project's own page, which lists what is in the project. The place you go to work on a project is its Tangent session, so the tile goes there instead and the page we had keeps its route, reached from the tile's menu as Details. A project route with no Tangent behind it now 404s rather than bouncing to the dashboard, so the reason the page did not open is visible instead of looking like a stray navigation. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Creating a project left you on the dashboard to find the new tile yourself. You made it in order to work in it, so it opens. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
camielvs
force-pushed
the
09-18-feat_run_a_pipeline_in_a_project
branch
from
September 23, 2026 20:57
0d1309e to
e369ae1
Compare
camielvs
force-pushed
the
09-18-feat_open_a_project_in_tangent
branch
from
September 23, 2026 20:57
58773a0 to
46de677
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes out of review on the projects stack, both about landing in the place you actually work on a project.
1. A project tile opens its Tangent session
Clicking a tile in My Projects opened the project's own page, which lists what the project holds. The place you go to work on a project is its Tangent session, so the tile goes there instead.
The page we built keeps its route and is reached from the tile's three-dots menu as Details.
The Tangent page takes the project from its path param (
/tangent/$projectId), whichTangentProjectPagealready reads — so linking withparamsis all the context it needs.2. Creating a project opens it
Creating a project left you on the dashboard to spot the new tile yourself. It now navigates to the new project's Tangent session on success.
The route now 404s instead of redirecting
The Tangent route is gated on
tangent-shell, and itsbeforeLoadused toredirectto the dashboard when the flag was off. Now that both paths above lead to Tangent, that redirect would read as a tile — or a freshly created project — silently dumping you on the dashboard.It throws
notFound()instead, rendering the root route's existingNotFoundPage, so the reason the page didn't open is visible.Worth a reviewer's eye: this changes flag-off behaviour for any navigation to
/tangent/$projectId, not just these two. Every other flag-gated route inrouter.tsredirects, so this is deliberately the odd one out.Left alone deliberately
Share still copies the
/projects/<id>URL rather than the Tangent one, so a shared link lands on a page that resolves regardless of the recipient's flags.Testing
pnpm run validateclean; 2978 tests pass, including new coverage for the tile's destination, the Details menu route, and the redirect after create. ThenotFound()gate itself is not unit-tested — nothing in the repo testsrouter.tsgating, since importing it pulls in the whole app tree.Not exercised in a browser: Tangent setup isn't configured locally yet, so the Tangent destination is unverified beyond the route wiring.
🤖 Generated with Claude Code