Skip to content

Remove KeyboardEvent.persist()#844

Open
Jaime02 wants to merge 1 commit intoTanStack:mainfrom
Jaime02:patch-1
Open

Remove KeyboardEvent.persist()#844
Jaime02 wants to merge 1 commit intoTanStack:mainfrom
Jaime02:patch-1

Conversation

@Jaime02
Copy link
Copy Markdown

@Jaime02 Jaime02 commented Apr 21, 2026

Summary by CodeRabbit

  • Chores
    • Internal code optimization in the search modal component with no impact on user-facing functionality or behavior.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 21, 2026

👷 Deploy request for tanstack pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit b0a23a2

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9c9e021a-3ad9-4e1c-a128-befb9537daa1

📥 Commits

Reviewing files that changed from the base of the PR and between 21bff8e and b0a23a2.

📒 Files selected for processing (1)
  • src/components/SearchModal.tsx
💤 Files with no reviewable changes (1)
  • src/components/SearchModal.tsx

📝 Walkthrough

Walkthrough

Removed the e.persist() call from the handleKeyDown event handler in SearchModal, eliminating reliance on React's event pooling behavior. The keyboard control flow for query options, focus management, item selection, and search dismissal remains unchanged.

Changes

Cohort / File(s) Summary
Event Handler Cleanup
src/components/SearchModal.tsx
Removed e.persist() from handleKeyDown handler to eliminate React event pooling dependency; keyboard interaction logic unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 One persist() gone, the code runs free,
No pools to worry, just the key!
React events flow like morning dew,
Simpler code, fresh and new.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Remove KeyboardEvent.persist()' directly matches the main change in the pull request, which removes the e.persist() call from the SearchModal's handleKeyDown event handler.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant