fix(router-core): load-client can cache settled abandoned loader work without preload authority - #8039
Conversation
…k without preload authority
|
View your CI Pipeline Execution ↗ for commit 618417b
☁️ Nx Cloud last updated this comment at |
🚀 Changeset Version Preview1 package(s) bumped directly, 22 bumped as dependents. 🟩 Patch bumps
|
📝 WalkthroughWalkthroughThe loader now checks and populates its cache for active regular navigations. Settled loader results can remain available after a superseded child navigation aborts. Documentation and release metadata describe the cache admission rules. ChangesLoader cache preservation
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bundle Size Benchmarks
The following scenarios have bundle-size changes compared with the baseline:
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better. |
Merging this PR will regress 0 benchmarks
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.changeset/cool-ideas-deny.md:
- Line 5: Update the release-note text in cool-ideas-deny.md by replacing
“settles” with “settled” and correcting “abandonned” to “abandoned,” preserving
the rest of the sentence exactly.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: a0da9453-c4b1-40c2-9024-02d495f3a39f
📒 Files selected for processing (2)
.changeset/cool-ideas-deny.mdpackages/router-core/INTERNALS.md
| '@tanstack/router-core': patch | ||
| --- | ||
|
|
||
| load-client can cache settles abandonned loader work without preload authority |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Correct the release-note wording.
Replace settles with settled and abandonned with abandoned. The corrected text is:
load-client can cache settled abandoned loader work without preload authority.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.changeset/cool-ideas-deny.md at line 5, Update the release-note text in
cool-ideas-deny.md by replacing “settles” with “settled” and correcting
“abandonned” to “abandoned,” preserving the rest of the sentence exactly.
Summary by CodeRabbit