Skip to content

wip for fix-router-core-lane-match-loader - #7911

Open
schiller-manuel wants to merge 5 commits into
fix-router-core-lane-match-loaderfrom
fix-match-rewrite
Open

wip for fix-router-core-lane-match-loader#7911
schiller-manuel wants to merge 5 commits into
fix-router-core-lane-match-loaderfrom
fix-match-rewrite

Conversation

@schiller-manuel

Copy link
Copy Markdown
Collaborator

No description provided.

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: bc292b08-41d3-403b-b111-f98da61ad3a6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-match-rewrite

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 8aa727f

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ❌ Failed 11m 43s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2m 11s View ↗

☁️ Nx Cloud last updated this comment at 2026-07-27 21:17:41 UTC

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

9 package(s) bumped directly, 19 bumped as dependents.

🟩 Patch bumps

Package Version Reason
@tanstack/react-router 1.170.18 → 1.170.19 Changeset
@tanstack/react-router-devtools 1.167.0 → 1.167.1 Changeset
@tanstack/router-core 1.171.15 → 1.171.16 Changeset
@tanstack/router-devtools 1.167.0 → 1.167.1 Changeset
@tanstack/router-devtools-core 1.168.0 → 1.168.1 Changeset
@tanstack/solid-router 1.170.18 → 1.170.19 Changeset
@tanstack/solid-router-devtools 1.167.0 → 1.167.1 Changeset
@tanstack/vue-router 1.170.17 → 1.170.18 Changeset
@tanstack/vue-router-devtools 1.167.0 → 1.167.1 Changeset
@tanstack/react-start 1.168.32 → 1.168.33 Dependent
@tanstack/react-start-client 1.168.16 → 1.168.17 Dependent
@tanstack/react-start-rsc 0.1.31 → 0.1.32 Dependent
@tanstack/react-start-server 1.167.22 → 1.167.23 Dependent
@tanstack/router-cli 1.167.21 → 1.167.22 Dependent
@tanstack/router-generator 1.167.21 → 1.167.22 Dependent
@tanstack/router-plugin 1.168.23 → 1.168.24 Dependent
@tanstack/router-vite-plugin 1.167.23 → 1.167.24 Dependent
@tanstack/solid-start 1.168.32 → 1.168.33 Dependent
@tanstack/solid-start-client 1.168.16 → 1.168.17 Dependent
@tanstack/solid-start-server 1.167.22 → 1.167.23 Dependent
@tanstack/start-client-core 1.170.14 → 1.170.15 Dependent
@tanstack/start-plugin-core 1.171.24 → 1.171.25 Dependent
@tanstack/start-server-core 1.169.17 → 1.169.18 Dependent
@tanstack/start-static-server-functions 1.167.19 → 1.167.20 Dependent
@tanstack/start-storage-context 1.167.17 → 1.167.18 Dependent
@tanstack/vue-start 1.168.31 → 1.168.32 Dependent
@tanstack/vue-start-client 1.167.19 → 1.167.20 Dependent
@tanstack/vue-start-server 1.167.22 → 1.167.23 Dependent

@github-actions

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: ce551300367e
  • Measured at: 2026-07-27T21:07:14.486Z
  • Baseline source: history:179d9b9b5eec
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

Scenario Current (gzip) Delta vs baseline Initial gzip Raw Brotli Trend
react-router.minimal 87.23 KiB -115 B (-0.13%) 87.10 KiB 269.42 KiB 75.85 KiB ███████████▁
react-router.full 91.01 KiB -58 B (-0.06%) 90.87 KiB 281.35 KiB 79.15 KiB ███████████▁
solid-router.minimal 34.88 KiB -657 B (-1.81%) 34.76 KiB 100.07 KiB 31.46 KiB ███████████▁
solid-router.full 39.99 KiB -602 B (-1.45%) 39.87 KiB 115.30 KiB 35.98 KiB ███████████▁
vue-router.minimal 52.16 KiB -861 B (-1.59%) 52.03 KiB 143.12 KiB 46.94 KiB ███████████▁
vue-router.full 58.13 KiB -831 B (-1.38%) 58.00 KiB 161.87 KiB 52.15 KiB ███████████▁
react-start.minimal 102.21 KiB +229 B (+0.22%) 102.07 KiB 318.13 KiB 88.64 KiB ▁▁▁▁▁▁▁▁▁▁▁█
react-start.deferred-hydration 102.95 KiB +237 B (+0.23%) 102.10 KiB 319.50 KiB 89.40 KiB ▁▁▁▁▁▁▁▁▁▁▁█
react-start.full 105.55 KiB +190 B (+0.18%) 105.41 KiB 328.13 KiB 91.51 KiB ▁▁▁▁▁▁▁▁▁▁▁█
react-start.rsbuild.minimal 99.95 KiB +279 B (+0.27%) 99.78 KiB 312.74 KiB 86.19 KiB ▁▁▁▁▁▁▁▁▁▁▁█
react-start.rsbuild.minimal-iife 100.35 KiB +282 B (+0.28%) 100.19 KiB 313.68 KiB 86.50 KiB ▁▁▁▁▁▁▁▁▁▁▁█
react-start.rsbuild.full 103.28 KiB +393 B (+0.37%) 103.11 KiB 322.89 KiB 89.02 KiB ▁▁▁▁▁▁▁▁▁▁▁█
solid-start.minimal 49.77 KiB +165 B (+0.32%) 49.64 KiB 147.73 KiB 44.18 KiB ▁▁▁▁▁▁▁▁▁▁▁█
solid-start.deferred-hydration 53.04 KiB +171 B (+0.32%) 49.70 KiB 155.77 KiB 47.23 KiB ▁▁▁▁▁▁▁▁▁▁▁█
solid-start.full 55.09 KiB -334 B (-0.59%) 54.96 KiB 163.52 KiB 48.75 KiB ███████████▁
vue-start.minimal 70.49 KiB -551 B (-0.76%) 70.36 KiB 200.63 KiB 62.55 KiB ███████████▁
vue-start.full 74.49 KiB -556 B (-0.72%) 74.36 KiB 213.24 KiB 66.08 KiB ███████████▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-new Bot commented Jul 27, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7911

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7911

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7911

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7911

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7911

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7911

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7911

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7911

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7911

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7911

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7911

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7911

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7911

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7911

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7911

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7911

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7911

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7911

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7911

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7911

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7911

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7911

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7911

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7911

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7911

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7911

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7911

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7911

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7911

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7911

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7911

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7911

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7911

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7911

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7911

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7911

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7911

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7911

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7911

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7911

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7911

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7911

commit: a6ce40a

@codspeed-hq

codspeed-hq Bot commented Jul 27, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 11.07%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 10 improved benchmarks
❌ 86 regressed benchmarks
✅ 84 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory mem server peak-large-page (react) 959.3 KB 2,093.3 KB -54.17%
Memory mem server error-paths not-found (vue) 332 KB 673.7 KB -50.72%
Memory mem client unique-location-churn (solid) 341.1 KB 666.5 KB -48.82%
Memory mem server error-paths not-found (react) 242.6 KB 445.3 KB -45.52%
Memory mem client navigation-churn (solid) 544.9 KB 822.4 KB -33.74%
Memory mem server aborted-requests (react) 562.3 KB 804 KB -30.06%
Memory mem server streaming-peak chunked (vue) 11.1 MB 15.3 MB -27.47%
Simulation ssr server-fn raw-stream (vue) 112.6 ms 150.8 ms -25.36%
Simulation ssr server-fn raw-stream (react) 109 ms 142.1 ms -23.26%
Simulation ssr server-fn raw-stream (solid) 111.7 ms 143.4 ms -22.11%
Simulation ssr global-mw server-route (vue) 68.3 ms 84.7 ms -19.4%
Simulation ssr server-fn raw-response (solid) 58.3 ms 71.9 ms -18.87%
Simulation ssr server-route (solid) 54.1 ms 66.6 ms -18.76%
Simulation ssr server-fn send-context (vue) 77.6 ms 93.6 ms -17.05%
Simulation ssr server-fn not-found (vue) 78.9 ms 94.8 ms -16.82%
Simulation ssr server-route (react) 56.5 ms 67.9 ms -16.77%
Simulation ssr server-route middleware (solid) 55.7 ms 66.8 ms -16.73%
Simulation ssr server-route (vue) 55.9 ms 67.1 ms -16.66%
Simulation ssr server-fn raw-response (react) 58.1 ms 69.6 ms -16.46%
Simulation ssr global-mw server-route (react) 58.8 ms 70.3 ms -16.38%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing fix-match-rewrite (a6ce40a) with fix-router-core-lane-match-loader (2d639e1)

Open in CodSpeed

@schiller-manuel schiller-manuel changed the title failing regression test for #4614 wip for fix-router-core-lane-match-loader Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant