Skip to content

devtools: update to solid 2#6838

Draft
birkskyum wants to merge 11 commits into
mainfrom
devtools-solid-2
Draft

devtools: update to solid 2#6838
birkskyum wants to merge 11 commits into
mainfrom
devtools-solid-2

Conversation

@birkskyum

@birkskyum birkskyum commented Mar 6, 2026

Copy link
Copy Markdown
Member

Updates router-devtools-core from solid v1 to v2.

Solid-Router etc. is still on solid v1 - this is possible because router-devtools-core is bundled.

Blocked by:

@coderabbitai

coderabbitai Bot commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 345f2f27-66a1-482e-a393-638515ece4d7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch devtools-solid-2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud

nx-cloud Bot commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

To disable these notifications, a workspace admin can disable them in workspace settings.


View your CI Pipeline Execution ↗ for commit f528f2e

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ❌ Failed 15m 53s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2m 2s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-07 01:44:21 UTC

@github-actions

github-actions Bot commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: b46b2eef6763
  • Measured at: 2026-03-07T01:29:19.940Z
  • Baseline source: history:b46b2eef6763
  • Dashboard: bundle-size history
Scenario Current (gzip) Delta vs baseline Raw Brotli Trend
react-router.minimal 86.84 KiB 0 B (0.00%) 273.33 KiB 75.44 KiB ▁▁▁▁▁▁█████
react-router.full 89.88 KiB 0 B (0.00%) 283.67 KiB 78.18 KiB ▁▁▁▁▁▁█████
solid-router.minimal 36.17 KiB 0 B (0.00%) 108.44 KiB 32.49 KiB ▁▁▁▁▁▁█████
solid-router.full 40.50 KiB 0 B (0.00%) 121.49 KiB 36.40 KiB ▁▁▁▁▁▁█████
vue-router.minimal 52.03 KiB 0 B (0.00%) 148.42 KiB 46.71 KiB ▁▁▁▁▁▁█████
vue-router.full 56.85 KiB 0 B (0.00%) 164.01 KiB 51.04 KiB ▁▁▁▁▁▁█████
react-start.minimal 99.40 KiB 0 B (0.00%) 312.48 KiB 85.98 KiB ▁▁▁▁▁▁█████
react-start.full 102.78 KiB 0 B (0.00%) 322.29 KiB 88.82 KiB ▁▁▁▁▁▁█████
solid-start.minimal 48.49 KiB 0 B (0.00%) 146.03 KiB 42.85 KiB ▁▁▁▁▁▁█████
solid-start.full 53.96 KiB 0 B (0.00%) 161.98 KiB 47.51 KiB ▁▁▁▁▁▁█████

Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-new Bot commented Mar 6, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@6838

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@6838

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@6838

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@6838

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@6838

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@6838

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@6838

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@6838

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@6838

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@6838

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@6838

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@6838

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@6838

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@6838

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@6838

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@6838

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@6838

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@6838

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@6838

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@6838

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@6838

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@6838

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@6838

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@6838

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@6838

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@6838

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@6838

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@6838

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@6838

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@6838

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@6838

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@6838

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@6838

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@6838

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@6838

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@6838

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@6838

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@6838

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@6838

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@6838

commit: d967b4f

@codspeed-hq

codspeed-hq Bot commented Mar 6, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 6 untouched benchmarks


Comparing devtools-solid-2 (f528f2e) with main (b46b2ee)

Open in CodSpeed

Comment thread packages/router-devtools-core/src/BaseTanStackRouterDevtoolsPanel.tsx Outdated
Comment thread packages/router-devtools-core/src/FloatingTanStackRouterDevtools.tsx Outdated
Comment thread packages/router-devtools-core/package.json Outdated

@brenelz brenelz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to change solid-router-devtools too or no?

@birkskyum

birkskyum commented Mar 6, 2026

Copy link
Copy Markdown
Member Author

Do we want to change solid-router-devtools too or no?

solid-router-devtools should stay on the same solid version as solid-router and solid-start, so not in this pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants