Repository navigation
Conversation
|
|
View your CI Pipeline Execution ↗ for commit 4223421
☁️ Nx Cloud last updated this comment at |
Contributor
🚀 Changeset Version Preview8 package(s) bumped directly, 16 bumped as dependents. 🟩 Patch bumps
|
Contributor
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes.
 |
| Layer / File(s) | Summary |
|---|---|
Standardize config-file patterns examples/angular/*/tsconfig.json, examples/preact/*/tsconfig.json, examples/react/*/tsconfig.json, examples/solid/*/tsconfig.json, examples/svelte/*/tsconfig.json, examples/vue/*/tsconfig.json |
The include lists use wildcard patterns for TypeScript and JavaScript config files instead of explicitly naming config files. |
Add tooling and server files to includes examples/lit/*/tsconfig.json, examples/react/eslint-legacy/tsconfig.json |
The Lit examples add config, development-script, or server files to their include lists. The React eslint-legacy example adds vite.config.ts. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix
Possibly related PRs
- TanStack/query#12401: Adds Preact examples whose TypeScript include lists are updated in this pull request.
- TanStack/query#12402: Adds Preact examples whose TypeScript include lists are updated in this pull request.
- TanStack/query#12407: Adds the Preact SSR example whose TypeScript include list is updated in this pull request.
Merge Risk: 
56d3c
-
The configuration-only changes are mergeable with no identified production or development workflow risk.
Pre-merge checks: 
-
Check name Status Explanation Title check The title clearly summarizes the main change: updating example tsconfig files to include *.config.ts and *.config.js patterns. Description check The description explains the motivation, identifies the affected files, documents the Lit-specific additions, completes the checklist, and states that the change has no release impact. Docstring Coverage No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (72 skipped: 72 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Contributor
size-limit report 📦
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
The example ESLint configs lint with type information from each example's
tsconfig.json, but many examples left their root config files out ofinclude(vite.config.tsin most Vite examples,next.config.jsin the Next.js examples). Opening those files in an editor reported "The file was not found in any of the provided project(s)".includelistedeslint.config.js, replace the individual config file entries (eslint.config.js,vite.config.ts,next.config.js) with"*.config.ts"and"*.config.js", the same patterns the packages' tsconfigs use.lit/{basic,pagination,ssr}: also include the server and config files the patterns don't cover (config/port(s).js,scripts/dev.mjs,server/index.mjs).✅ Checklist
pnpm run test:pr, or these tests do not apply to this pull request.🚀 Release Impact
Summary by CodeRabbit