Add agent-safe hidden source handling to intent list#176
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds agent-safe handling for hidden skill sources in ChangesAgent-safe hidden skill source redaction
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 31174b4
☁️ Nx Cloud last updated this comment at |
commit: |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/intent/src/core/source-policy.ts`:
- Around line 13-22: The import statements in source-policy.ts violate ESLint's
import/order rule because parent directory imports should be ordered before
sibling/child directory imports. Reorder the imports so that imports from parent
directories (starting with ../shared/environment.js and ../skills/use.js) appear
before all the relative imports from the current directory (./excludes.js,
./project-context.js, ./skill-sources.js, and ./types.js). This ensures
compliance with the configured import ordering rules.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 907834c8-c3b5-45a8-8765-c35c980a7f0a
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (11)
.changeset/thick-snakes-yell.mddocs/cli/intent-list.mdpackages/intent/package.jsonpackages/intent/src/cli.tspackages/intent/src/commands/list.tspackages/intent/src/core/intent-core.tspackages/intent/src/core/source-policy.tspackages/intent/src/core/types.tspackages/intent/src/shared/environment.tspackages/intent/tests/cli.test.tspackages/intent/tests/core.test.ts
Summary
std-envbased audience detection for agent vs humanintent listoutputintent list --show-hiddenso human sessions can review hidden source names, while agent sessions get a refusal messageSummary by CodeRabbit
--show-hiddenoption tointent listfor revealing hidden/unlisted skill sources when allowed.--jsonoutput to includehiddenSourceCountandhiddenSources(with agent-safe redaction).intent listCLI docs to document--show-hiddenand the updated JSON schema.INTENT_AUDIENCE-specific behavior in both CLI and core logic.