Repository navigation
Conversation
CyanVoxel
added
Type: Refactor
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR is targeting the
devbranch for release with Alpha v9.7.Summary
This PR fully aligns
wcmatchandripgrepbehavior, fixing issues that stemmed from those leftover discrepancies (like #1529). Performance parsing long ignore lists should also be improved, which has been a big issue up to this point, but I only have my own anecdotal experiences on that. I've also added a ton of new tests to hopefully fully lock in the intended behavior.These changes are built on top of #1501 and were originally going to be included in that PR, but since these changes were isolated to the ignore system I decided it would be easy enough to split off into a separately tracked PR since that one was already big enough.
Fixes #1529.
Tasks Completed