Repository navigation
fix: block uncertain writes across checkpoint resume paths - #33
Merged
Merged
Conversation
6 tasks done
Owner
Author
|
The previously announced review window has not quite ended, but there are no outstanding change requests, so I am wrapping up the review and merging this now. The head remains This will close #7 and is planned for 0.3.4. Thanks to everyone following the session-recovery work! |
This was referenced Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7.
An interrupted
writewas classified as read-only, and interactive/resume/--continuecould load its pending checkpoint without the uncertainty check. This can continue a conversation without knowing whether the write took effect.This patch records new writes as mutating and checks both the stored flag and current classification, covering legacy journals with
mutating: false. Core, journal and interactive continuation refuse uncertain execution before installing history or calling the model. A failed--continuealso does not silently submit its initial task as a new run. Read-only and completed interactive conversations remain resumable; existing compatibility checks and journal format are unchanged.Validation:
/resumeand--continue× legacy false / true write / read-only / completed, all 8 cases pass. Refusal leaves history/channel intact and sends zero model requests.pnpm test: 726 tests across 42 files;pnpm typecheck,pnpm build,pnpm lint:tools, andgit diff --checkpass locally. GitHub CI passes all five jobs: Node 20/22, Linux ARM64, Python, and template goldens.Review window: until 2026-09-25 00:30 KST (2026-09-24 15:30 UTC). Please review this PR over the next two days, especially legacy journal compatibility and interactive continuation. It will remain open for review; no merge or release is part of this change.