feat(views): add PostgreSQL materialized views support by Davydhh · Pull Request #342 · TabularisDB/tabularis

Davydhh · 2026-06-20T15:46:24Z

Part of #16

Adds PostgreSQL materialized views to the schema tree.

What you can do

Browse materialized views in a dedicated Materialized Views group per schema
Expand to see columns and indexes
Show definition (read-only CREATE MATERIALIZED VIEW …)
Refresh via REFRESH MATERIALIZED VIEW
Open data / count rows like any other relation

kilo-code-bot · 2026-06-20T15:53:36Z

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (18 files)

src-tauri/src/drivers/driver_trait.rs - Capability comment updated
src-tauri/src/drivers/postgres/mod.rs - Removed unnecessary &query reference
src/components/layout/ExplorerSidebar.tsx - Refresh spinner state and context-menu feedback
src/components/layout/sidebar/SidebarIndexList.tsx - New shared index list component
src/components/layout/sidebar/SidebarSchemaItem.tsx - Default collapse + isRefreshing pass-through
src/components/layout/sidebar/SidebarTableItem.tsx - Uses shared SidebarIndexList
src/components/layout/sidebar/SidebarViewItem.tsx - Uses shared SidebarIndexList + refresh spinner
src/contexts/DatabaseProvider.tsx - Gates materialized-view fetch on materialized_views capability
src/i18n/locales/de.json - Materialized view translations
src/i18n/locales/es.json - Materialized view translations
src/i18n/locales/fr.json - Materialized view translations
src/i18n/locales/it.json - Materialized view translations
src/i18n/locales/ja.json - Materialized view translations
src/i18n/locales/ru.json - Materialized view translations
src/i18n/locales/zh.json - Materialized view translations
src/types/plugins.ts - Capability comment updated
src/utils/indexes.ts - New groupIndexes utility
tests/components/layout/sidebar/SidebarViewItem.test.tsx - Refresh spinner + materialized view tests

Previous Review Summaries (2 snapshots, latest commit af110d2)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit `af110d2`)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (18 files)

src-tauri/src/drivers/driver_trait.rs - Capability comment updated
src-tauri/src/drivers/postgres/mod.rs - Removed unnecessary &query reference
src/components/layout/ExplorerSidebar.tsx - Refresh spinner state and context-menu feedback
src/components/layout/sidebar/SidebarIndexList.tsx - New shared index list component
src/components/layout/sidebar/SidebarSchemaItem.tsx - Default collapse + isRefreshing pass-through
src/components/layout/sidebar/SidebarTableItem.tsx - Uses shared SidebarIndexList
src/components/layout/sidebar/SidebarViewItem.tsx - Uses shared SidebarIndexList + refresh spinner
src/contexts/DatabaseProvider.tsx - Gates materialized-view fetch on materialized_views capability
src/i18n/locales/de.json - Materialized view translations
src/i18n/locales/es.json - Materialized view translations
src/i18n/locales/fr.json - Materialized view translations
src/i18n/locales/it.json - Materialized view translations
src/i18n/locales/ja.json - Materialized view translations
src/i18n/locales/ru.json - Materialized view translations
src/i18n/locales/zh.json - Materialized view translations
src/types/plugins.ts - Capability comment updated
src/utils/indexes.ts - New groupIndexes utility
tests/components/layout/sidebar/SidebarViewItem.test.tsx - Refresh spinner + materialized view tests

Previous review (commit `82f1f77`)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (14 files)

src-tauri/src/commands.rs - 4 new Tauri commands for materialized views
src-tauri/src/drivers/driver_trait.rs - Trait default impls + capability flag
src-tauri/src/drivers/mysql/mod.rs - materialized_views: false capability
src-tauri/src/drivers/postgres/mod.rs - Full PostgreSQL implementation
src-tauri/src/drivers/sqlite/mod.rs - materialized_views: false capability
src-tauri/src/lib.rs - Command registrations
src/components/layout/ExplorerSidebar.tsx - Context menu for materialized views
src/components/layout/sidebar/SidebarSchemaItem.tsx - Tree group rendering
src/components/layout/sidebar/SidebarViewItem.tsx - Columns + indexes expansion
src/contexts/DatabaseContext.ts - materializedViews field added to SchemaData
src/contexts/DatabaseProvider.tsx - Loading materialized views in schema fetches
src/i18n/locales/en.json - Localization strings
src/types/plugins.ts - Frontend materialized_views capability
tests/components/layout/sidebar/SidebarViewItem.test.tsx - Tests for materialized view path

_{Reviewed by nemotron-3-ultra-550b-a55b-20260604:free · Input: 404K · Output: 2.6K · Cached: 105.7K}

kilo-code-bot · 2026-06-20T15:53:36Z

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (14 files)

src-tauri/src/commands.rs - 4 new Tauri commands for materialized views
src-tauri/src/drivers/driver_trait.rs - Trait default impls + capability flag
src-tauri/src/drivers/mysql/mod.rs - materialized_views: false capability
src-tauri/src/drivers/postgres/mod.rs - Full PostgreSQL implementation
src-tauri/src/drivers/sqlite/mod.rs - materialized_views: false capability
src-tauri/src/lib.rs - Command registrations
src/components/layout/ExplorerSidebar.tsx - Context menu for materialized views
src/components/layout/sidebar/SidebarSchemaItem.tsx - Tree group rendering
src/components/layout/sidebar/SidebarViewItem.tsx - Columns + indexes expansion
src/contexts/DatabaseContext.ts - materializedViews field added to SchemaData
src/contexts/DatabaseProvider.tsx - Loading materialized views in schema fetches
src/i18n/locales/en.json - Localization strings
src/types/plugins.ts - Frontend materialized_views capability
tests/components/layout/sidebar/SidebarViewItem.test.tsx - Tests for materialized view path

debba · 2026-06-22T14:23:07Z

Nice work, the default trait impls keep the other drivers clean. A few things I'd want sorted before merging:

Translations — only en.json got the new keys. sidebar.materializedViews, sidebar.refreshMaterializedView, sidebar.showDefinition, views.refreshSuccess/refreshError/failGetDefinition are missing in it/es/de/fr/ja/ru/zh, so those locales will show English. We keep all 8 in sync.

The materialized_views capability flag isn't actually used. It's added to both the Rust DriverCapabilities and types/plugins.ts, and the doc comment says it gates the tree group in the UI, but nothing reads it. The group renders off materializedViews.length > 0 in SidebarSchemaItem, and DatabaseProvider calls get_materialized_views for every driver in all three load paths. So MySQL/SQLite/plugins fire an extra invoke on every schema load just to get back []. Either gate the invoke on the capability (which is the whole point of the flag) or drop the flag and fix the comment.

Refresh has no UI feedback. REFRESH MATERIALIZED VIEW takes an ACCESS EXCLUSIVE lock and can run for a while on big matviews, but the frontend shows nothing until the success/error alert. A disabled state or spinner while the call is in flight would help. Not asking for CONCURRENTLY here — that needs a unique index, separate discussion.

Index list styling — in SidebarViewItem the index sub-tree uses literal colors (text-green-400, text-blue-400, border-strong) instead of the theme tokens the rest of the sidebar uses. The grouping + rendering also looks close to what we already do for table indexes; worth reusing instead of a second copy.

Smaller stuff:

get_materialized_view_definition rebuilds the DDL from pg_get_viewdef, so it loses storage params / tablespace / WITH [NO] DATA. Fine for a read-only view, just noting it's not the exact statement.
materializedViewsOpen defaults to true while routines/triggers default to false.
get_materialized_view_columns passes &query (a &&str) where get_materialized_views passes the literal — the & isn't needed.
No Rust tests for the four new Postgres functions, though that matches the existing driver code.

Checked and these are fine: double-click goes through handleOpenView so SELECT * FROM … works, and the relkind IN ('r','m') change in get_indexes is what lets matview indexes load.

…rialized views

…lumns

Davydhh · 2026-06-24T20:11:41Z

Thanks for the review — agree with all the points. All addressed, except the two you flagged as fine-as-is: the definition isn't byte-exact (added a comment noting it' reconstructed from pg_get_viewdef), and no Rust tests for the four wrappers (matches the existing driver code).

debba · 2026-07-01T14:09:48Z

@Davydhh This looks great overall, really nice work.

One thing though: as far as I know materialized views in Postgres are read-only — you can't insert, update or delete rows directly, the only write operation is REFRESH. So we should disable data editing (cell edits, adding and deleting rows) for materialized views in the grid.

Once that's handled and the conflicts are resolved, I'll go ahead and merge. Thanks!

Resolve conflicts in two sidebar components: - SidebarViewItem: keep the materialized-view icon (Layers) and refresh spinner; adopt upstream's text-accent-secondary color. - SidebarTableItem: keep the shared SidebarIndexList component; fold upstream's aria-expanded improvement into SidebarIndexList.

Davydhh · 2026-07-01T18:04:12Z

@debba Good catch, thanks! You're right that materialized views only accept REFRESH, so I've made them read-only in the grid. I've also merged the latest main to clear the conflicts.

feat(views): add PostgreSQL materialized views support

82f1f77

debba self-requested a review June 22, 2026 14:17

Davide Cazzetta added 6 commits June 23, 2026 21:47

chore(i18n): add materialized views translations for all locales

66d7d67

refactor(views): gate materialized-view fetch on driver capability

bf6256d

feat(views): show in-flight spinner while refreshing a materialized view

5ba2bfc

refactor(sidebar): share index list rendering between tables and mate…

0ffb555

…rialized views

fix(views): collapse the materialized views group by default

a464076

refactor(views): drop redundant reference in get_materialized_view_co…

af110d2

…lumns

Davide Cazzetta added 3 commits July 1, 2026 18:27

fix(views): make materialized views read-only in the data grid

1bbddab

fix(views): resolve materialized views from the active schema

f4b3afc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(views): add PostgreSQL materialized views support#342

feat(views): add PostgreSQL materialized views support#342
Davydhh wants to merge 10 commits into
TabularisDB:mainfrom
Davydhh:feat/postgres-materialized-views

Davydhh commented Jun 20, 2026

Uh oh!

kilo-code-bot Bot commented Jun 20, 2026 •

edited

Loading

Previous review (commit `af110d2`)

Previous review (commit `82f1f77`)

Uh oh!

kilo-code-bot Bot commented Jun 20, 2026

Uh oh!

debba commented Jun 22, 2026

Uh oh!

Davydhh commented Jun 24, 2026

Uh oh!

debba commented Jul 1, 2026

Uh oh!

Davydhh commented Jul 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

Davydhh commented Jun 20, 2026

What you can do

Uh oh!

kilo-code-bot Bot commented Jun 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Summary

Previous review (commit af110d2)

Previous review (commit 82f1f77)

Uh oh!

kilo-code-bot Bot commented Jun 20, 2026

Code Review Summary

Uh oh!

debba commented Jun 22, 2026

Uh oh!

Davydhh commented Jun 24, 2026

Uh oh!

debba commented Jul 1, 2026

Uh oh!

Davydhh commented Jul 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kilo-code-bot Bot commented Jun 20, 2026 •

edited

Loading

Previous review (commit `af110d2`)

Previous review (commit `82f1f77`)