fix: split manifest id and display name in .tabularium - #117
Merged
Merged
Conversation
Adds "id": "postgresql" as the stable registry slug and changes
"name" to the human-readable display name ("PostgreSQL"), per the
Tabularium 0.14.0+ identity/display-name split (tabularis#795,
tabularis#759). Existing registry slug and driver id are unchanged.
aesslinger
added
the
prerelease:rc
Version suggestionBased on this PR's title (
This is informational only — no tag or release is created automatically yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"id": "postgresql"as the stable registry slug and changes"name"to the human-readable display name ("PostgreSQL") in.tabularium.idis now the stable identifier,nameis the display name shown in the UI.postgresql) are unchanged — this only affects how the plugin's display name renders in places that read the manifest'snamefield directly (installed-plugin list, update dialogs, etc). The catalogue's engine group card is unaffected either way, sincepostgresqlis already a known/shared engine in tabularis'sENGINE_DISPLAY_NAMESmap..tabulariumalready hadkind/engine/paradigms, which is the other part of that PR's example manifest, so no further changes needed there.min_runtime_version(0.20.0) already exceeds the0.14.0needed for this manifest format, so no bump required.Test plan
.tabulariumstill parses as valid JSON.