fix: run version-suggestion as pull_request_target so fork PRs get a writable token - #116
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
version-suggestionjob out ofci.ymlinto its own workflow,.github/workflows/version-suggestion.yml, triggered onpull_request_targetinstead ofpull_request.pull_request_targetruns with the base repo's token permissions even for fork-originated PRs, fixing the403when posting the version-suggestion comment.github.event.pull_request.title/body/labelsfrom the event payload — so this is safe, per option 1 in the issue.labeled/unlabeledfromci.yml'spull_requesttrigger types since those were only needed for this job, which now has its own trigger types in the new file. Avoids redundant reruns of unrelated CI jobs (test, clippy, markdownlint, etc.) on label changes.Fixes #115.
Test plan
actionlintpasses on bothci.ymlandversion-suggestion.yml(pre-existing shellcheck style warnings in the copied script body confirmed present onmainbefore this change too)markdownlintclean (no.mdchanges)Version suggestionnow posts/updates a comment instead of 403ing