Conversation
DotNetCoreAssemblyResolver.AddLib previously fell back to DefaultAssemblyResolver when an assembly couldn't be found. Since DefaultAssemblyResolver loads assemblies with itself as the resolver, later TypeReference.Resolve() calls threw AssemblyResolutionException instead of returning null. The fallback now passes the original ReaderParameters so loaded assemblies keep using DotNetCoreAssemblyResolver. All .Resolve() call sites that didn't catch AssemblyResolutionException are switched to TryResolve helpers that return null on failure. Signed-off-by: Malte Kunath <malte.kunath@tngtech.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #502 +/- ##
==========================================
- Coverage 86.33% 86.20% -0.14%
==========================================
Files 260 261 +1
Lines 12496 12543 +47
Branches 1216 1221 +5
==========================================
+ Hits 10789 10813 +24
- Misses 1372 1392 +20
- Partials 335 338 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #497
DotNetCoreAssemblyResolver.AddLib previously fell back to DefaultAssemblyResolver when an assembly couldn't be found. Since DefaultAssemblyResolver loads assemblies with itself as the resolver, later TypeReference.Resolve() calls threw AssemblyResolutionException instead of returning null.
The fallback now passes the original ReaderParameters so loaded assemblies keep using DotNetCoreAssemblyResolver. All .Resolve() call sites that didn't catch AssemblyResolutionException are switched to TryResolve helpers that return null on failure.