feat(segy): add update_segy_file_headers - #863
Merged
BrianMichell merged 3 commits intoSep 16, 2026
Merged
Conversation
Ingest may skip text/binary file headers. Export needs them. Write attrs only so traces stay untouched. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #863 +/- ##
==========================================
+ Coverage 85.30% 93.12% +7.81%
==========================================
Files 46 150 +104
Lines 2219 8702 +6483
Branches 306 497 +191
==========================================
+ Hits 1893 8104 +6211
- Misses 281 518 +237
- Partials 45 80 +35 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Default header generation used hardcoded 4000/1500 values, silently writing wrong trace geometry into stores that lack a binary header. Derive sample_interval and samples_per_trace from the fastest dimension, and raise when spacing is absent, zero, or fractional. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ingest may skip text/binary file headers. Export needs them. Write attrs only so traces stay untouched. Also provide a helper function/example for how to update the text header and binary header in place.