Skip to content

Display formulas using math plugin instead of ..centered - #66

Merged
llpeterson merged 2 commits into
SystemsApproach:mainfrom
Walentalien:fix/transfer-time-formulas
Oct 1, 2026
Merged

llpeterson merged 2 commits into
SystemsApproach:mainfrom
Walentalien:fix/transfer-time-formulas

Conversation

@Walentalien

Copy link
Copy Markdown
Contributor

with ..centered:
image
Using math:
image

If that makes sense i can look at usage of centered later in the book as well.

It's also a deprecated directive: https://www.sphinx-doc.org/en/master/usage/restructuredtext/directives.html#directive-centered

@llpeterson

Copy link
Copy Markdown
Contributor

That looks better. I vaguely remember there being a problem when I first converted the text to Sphinx, but I don't remember what it was... Probably just my inexperience with Sphinx.

@drbruced12 drbruced12 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems wise to move away from a deprecated directive. I think we would like this better if the mathsf font is used rather than mathrm.
There are 13 instances of this directive, so I guess we should fix them all.

@llpeterson

Copy link
Copy Markdown
Contributor

Second Bruce's "mathsf" comment.

Signed-off-by: Walentalien <voliinyk@student.agh.edu.pl>
@Walentalien
Walentalien force-pushed the fix/transfer-time-formulas branch from 7a16856 to aaa48bc Compare October 1, 2026 10:25
Comment thread reliable/design.rst
RTT, if we assume a packet size of 1 KB, this implies a maximum
sending rate of

.. centered:: Bits-Per-Packet / Time-Per-Packet = 1024 x 8 / 0.045 = 182 kbps

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed hyphenated writing to camel case. Look bad when using math directive beause need to escape - sign
Also camel case already used extensively

@Walentalien
Walentalien requested a review from drbruced12 October 1, 2026 10:36
Signed-off-by: Walentalien <voliinyk@student.agh.edu.pl>
@llpeterson
llpeterson merged commit acd3f4f into SystemsApproach:main Oct 1, 2026
2 checks passed
@Walentalien
Walentalien deleted the fix/transfer-time-formulas branch October 1, 2026 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants