Repository navigation
perf: first use also reads the docs sites - #58
Merged
Merged
Conversation
Contributor
|
QA PASS @30cd340 - automatic first-use fetch now also reads docs sites (site failure keeps package docs and notes it in the manifest; explicit fetch still errors); redirect follow is once and same API host only, so the token is not sent elsewhere; two new unit tests plus the bench floor (first-use-default >= 88/105); bench, test (3 OS), manifests/smoke/docs checks completed green; merges cleanly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First-use (before
lockdocs fetch) never read docs-site repositories, so React 19, Express, tokio and Tailwind answers came from package files only.Root causes, from the first-use misses (local run, empty isolated cache, no credentials, 97 of 105 questions installable here, pydantic 2 excluded):
First-use column, local, same 97 questions, before -> after: total 76 -> 88; older major 34/45 -> 38/45; newer major 38/47 -> 45/47; single version 4/5 -> 5/5; held-out 13/16 -> 14/16 (react19-context and tw3-source fixed; tw4-source now misses, same as explicit fetch, since the site page outranks the package file). Keyword 55/97 and hybrid 59/97 unchanged. Median latency 122 -> 149 ms, p95 3.4 -> 5.6 s (the one-time site fetch). Context7 not run here.
Floor:
bench/run.pyfirst-use-default >= 88/105 (CI to confirm).upstream::FORMAT6. Caches of format 5 stay trusted;lockdocs fetchrefreshes them. cargo test --workspace and clippy -D warnings pass locally.