Repository navigation
fix(just): give cluster::reseed's port-forward a real service name - #322
Merged
Merged
Conversation
`postgres_svc := "svc/{{postgres_sts}}"` was never interpolated: just
does not expand {{…}} inside a variable's value, so the port-forward
was handed the literal `svc/{{postgres_sts}}`. kubectl refuses it
after the app database has already been dropped, so reseed left dev
empty instead of seeded. Name the Service like the other resources and
let the port-forward add the `svc/` prefix, as exec adds `sts/`.
Also move the comment on restoring a backend found at 0 next to the
lines it explains.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
postgres_svc := "svc/{{postgres_sts}}"was never interpolated: just does not expand {{…}} inside a variable's value, so the port-forward was handed the literalsvc/{{postgres_sts}}. kubectl refuses it after the app database has already been dropped, so reseed left dev empty instead of seeded. Name the Service like the other resources and let the port-forward add thesvc/prefix, as exec addssts/.Also move the comment on restoring a backend found at 0 next to the lines it explains.