Fixed conversion of variable refresh rate videos - #539
Conversation
Also added a new Docker ARG: VIDEO_BUFFER_SIZE with default value 600K, useful to quickly change directly in production the max size of the buffer used in 2pass video conversion, in case some files conversion result in videos greater than the maximum file size allowed
📝 WalkthroughWalkthroughChangesThe change migrates external command execution to list-based APIs, adds WebM bitrate fallback encoding and coverage, enables final-field mutation in JVM runs, and updates Unix and Windows startup script templates. Media and runtime startup
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 4
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 4736d458-3b36-4b51-a77e-68c56b409a80
⛔ Files ignored due to path filters (1)
src/test/resources/highly_accurate_fps_count.mp4is excluded by!**/*.mp4,!**/*.mp4
📒 Files selected for processing (6)
Railway.dockerfilebuild.gradlesrc/main/java/com/github/stickerifier/stickerify/media/MediaHelper.javasrc/main/resources/customUnixStartScript.txtsrc/main/resources/customWindowsStartScript.txtsrc/test/java/com/github/stickerifier/stickerify/media/MediaHelperTest.java
Also renamed the ARG to VIDEO_BITRATE_LIMIT
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: eb6a4b4e-1bda-4618-b59a-695079b019f0
📒 Files selected for processing (3)
src/main/java/com/github/stickerifier/stickerify/media/MediaHelper.javasrc/main/java/com/github/stickerifier/stickerify/process/ProcessHelper.javasrc/test/java/com/github/stickerifier/stickerify/media/MediaHelperTest.java
Summary by CodeRabbit
Bug Fixes
Tests
Chores