Repository navigation
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 63 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Contributor
There was a problem hiding this comment.
2 issues found across 24 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="docs/algorithms/linear-programming/solve-lp.md">
<violation number="1" location="docs/algorithms/linear-programming/solve-lp.md:98">
P3: This omits the finite-step condition: `_gain_column` skips columns whose ratio limit is infinite, so a reduced cost within `eps` on an unbounded direction does not enter through this check. Specify that the gain must occur over a finite feasible step.</violation>
</file>
<file name="docs/algorithms/linear-programming/solve-milp.md">
<violation number="1" location="docs/algorithms/linear-programming/solve-milp.md:61">
P2: With the default `seed=None`, LNS runs are not repeatable, despite the unconditional same-call-sequence guarantee below. State that callers must supply a seed for reproducibility and qualify that guarantee for LNS.</violation>
</file>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Merges
devintomainas release 0.6.3. Adds new LP/MILP input forms (sparse rows, per-row senses, variable bounds, binary variables), an incrementalMilpModelwith warm re-solves, and makesstrongly_connected_components,articulation_pointsandbridgesiterative so deep graphs no longer raiseRecursionError. Graph and solver results no longer depend on set/input order, and the Python and Rust backends are bit-identical.Behavior changes
solve_lpandsolve_milpaccept sparse rows,senses,lb/ubandbinary; the 0.6.2 call form stays unchanged.MilpModeladds rows and re-solves warm from a kept simplex basis;solve_lexicographicoptimizes objectives in priority order.tol.pagerankbackend.Tooling and release
rust/Cargo.toml; publishing builds abi3 wheels per platform with maturin and reads the release tag from Cargo.toml.rust-toolchain.toml, PyO3 bumped to 0.29 withabi3-py312, and the minimum supported Rust is 1.88; lint and type-check CI no longer build the extension, and a newrust-lintjob runs clippy on the pinned toolchain.Result changes.Written for commit fb68414. Summary will update on new commits.