fix: add withdrawal validation with balance and liquidity checks (#89) - #94
Merged
Merged
Conversation
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem this solves
The withdrawal form on the Sponsors page validates only that the share amount is a positive number. It never checks the requested shares against the sponsor's actual share balance or against the pool's available liquidity. This leads to sponsors signing and submitting transactions that are guaranteed to fail on-chain, and the Preview Value block quotes payouts for shares the user does not own.
Closes #89
What was built
How it was tested
pm run build\ — passes with zero errors
pm test\ — all 49 tests pass across 10 test files (13 new tests added)
Files touched
Closes #89