fix: enforce ESLint in CI and add a check-only lint script (#101) - #111
Open
Marvelg256 wants to merge 1 commit into
Open
fix: enforce ESLint in CI and add a check-only lint script (#101)#111Marvelg256 wants to merge 1 commit into
Marvelg256 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
@typescript-eslint/no-explicit-anyrule is set toerrorin.eslintrc.js, andcontext/code-standards.mdstates it is "enforced by ESLint, not just documentation." However, CI had no lint step — onlynpm ci,npm run build, andnpm test. A PR reintroducinganypassed CI cleanly.The existing
lintscript used--fix, which rewrites files locally and does not reliably exit non-zero on violations it cannot auto-fix. There was no check-only variant for CI.The codebase is currently clean (all 32 explicit
anyusages removed on 2026-07-16, zero found insrc/today), but this was unprotected.Changes
package.jsonlint:checkscript:eslint "{src,apps,libs,test}/**/*.ts" --max-warnings=0(no--fix)lintscript with--fixkept untouched for local developer use.github/workflows/ci.ymlLintstep (npm run lint:check) afterInstall dependenciesand beforeBuild, so a lint failure reports quicklycontext/progress-tracker.mdAcceptance criteria verification
npm run lint:checkexits non-zero whenanyinsrc/const x: any = 1tosrc/app.module.ts, got@typescript-eslint/no-explicit-anyerror, exit 1)npm run lint:checkdoes not modify files--fixflaglint:checkon every PR tomainci.yml(on: pull_request: [main])lintwith--fixstill worksnpm run buildexits 0npm run lint:checkexits 0 before changesEvidence that a violation fails CI
Locally verified by temporarily introducing
const x: any = 1intosrc/app.module.tsand runningnpm run lint:check:Exit code:
1— the step will fail CI.Closes #101