Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR prepares the 1.7.3 release by migrating the build toolchain to tsdown, tightening linting rules, and refactoring manager internals (including adding load-time logging).
Changes:
- Switch build pipeline from
tsc/tsc-aliastotsdownand update package exports for ESM distribution. - Refactor interaction managers to use clearer collection names and add “Loaded N …” log statements.
- Update ESLint configuration (move to
eslint-plugin-import-x) and adjust formatting/tooling configs.
Reviewed changes
Copilot reviewed 17 out of 19 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tsdown.config.ts | Adds tsdown bundler config including ESM output, DTS generation, and aliases. |
| tsconfig.json | Removes build-output-focused options now that build is handled by tsdown. |
| src/utils/translation.ts | Converts i18n import to type-only import. |
| src/structures/Interaction.ts | Formatting changes to interface method signatures and conditional type. |
| src/managers/SelectMenuManager.ts | Renames internal collection and adds “loaded” logging. |
| src/managers/ModalManager.ts | Renames internal collection and adds “loaded” logging. |
| src/managers/EventManager.ts | Renames internal collection, adds “loaded” logging, and formatting cleanup. |
| src/managers/ContextMenuManager.ts | Renames internal collection and adds “loaded” logging. |
| src/managers/CommandManager.ts | Renames internal collection and adds “loaded” logging. |
| src/managers/ButtonManager.ts | Renames public collection field and adds “loaded” logging. |
| src/managers/BaseManager.ts | Changes Collection import to type-only. |
| src/managers/AutoCompleteManager.ts | Renames internal collection and adds “loaded” logging. |
| src/client/StelliaClient.ts | Import formatting + multi-line generic signature formatting. |
| pnpm-workspace.yaml | Adds pnpm workspace configuration to allow specific builds. |
| package.json | Updates version to 1.7.3, switches build script to tsdown, adds ESM exports, updates engines/tooling deps. |
| eslint.config.ts | Migrates to eslint-plugin-import-x and expands/updates lint rules and resolver settings. |
| .prettierrc | Lowers printWidth from 150 to 140. |
| .github/workflows/publish-npm.yml | Updates pnpm action setup from v5 to v6. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
+2
| allowBuilds: | ||
| unrs-resolver: true |
| "engines": { | ||
| "node": ">=24.0.0" | ||
| }, | ||
| "engineStrict": true, |
| "exports": { | ||
| ".": { | ||
| "types": "./dist/index.d.ts", | ||
| "import": "./dist/index.mjs" |
| export class ButtonManager extends BaseManager<ButtonStructure> { | ||
| public interactions: Collection<StructureCustomId, ButtonStructure> = new Collection(); | ||
| public buttons: Collection<StructureCustomId, ButtonStructure> = new Collection(); | ||
|
|
Comment on lines
18
to
19
| import { requiredFiles } from "@utils/index.js"; | ||
| import { logger } from "@utils/logger.js"; |
Comment on lines
+9
to
+14
| "@client": "./src/client", | ||
| "@constants": "./src/constants", | ||
| "@managers": "./src/managers", | ||
| "@structures": "./src/structures", | ||
| "@typescript": "./src/typescript", | ||
| "@utils": "./src/utils" |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.