Skip to content

Pre release 1.0#59

Merged
benjaminaubin merged 12 commits into
mainfrom
pre-release-1.0
Jul 26, 2023
Merged

Pre release 1.0#59
benjaminaubin merged 12 commits into
mainfrom
pre-release-1.0

Conversation

@benjaminaubin
Copy link
Copy Markdown
Contributor

@benjaminaubin benjaminaubin self-assigned this Jul 25, 2023
@benjaminaubin benjaminaubin requested a review from palp July 25, 2023 13:16
@benjaminaubin benjaminaubin marked this pull request as draft July 25, 2023 13:16
@benjaminaubin benjaminaubin requested a review from rromb July 25, 2023 13:33
@rromb rromb requested review from ablattmann and timudk July 25, 2023 13:44
@akx
Copy link
Copy Markdown
Contributor

akx commented Jul 25, 2023

The LPIPS vendoring isn't necessary if #50 is merged.

Comment thread sgm/__init__.py
Comment thread sgm/modules/diffusionmodules/lpips/lpips.py
Comment thread sgm/modules/diffusionmodules/lpips/model.py
Comment thread sgm/modules/autoencoding/losses/__init__.py Outdated
Comment thread requirements/pt13.txt
Comment thread requirements/pt2.txt
@benjaminaubin
Copy link
Copy Markdown
Contributor Author

benjaminaubin commented Jul 25, 2023

The LPIPS vendoring isn't necessary if #50 is merged.

Yes but we decided internally to not merge #50 for the future release
This LPIPS refactoring would have been necessary at some point in any case

Comment thread sgm/modules/autoencoding/lpips/vqperceptual.py Outdated
Comment thread sgm/modules/autoencoding/lpips/model/model.py
Comment thread sgm/__init__.py
@benjaminaubin benjaminaubin changed the title Pre release 1.0 Pre release Jul 25, 2023
@akx akx mentioned this pull request Jul 25, 2023
palp
palp previously approved these changes Jul 25, 2023
Copy link
Copy Markdown
Contributor

@palp palp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've merged this with #57 on my fork here and confirmed the tests pass & upstream dependencies are working, so this looks good from my perspective.

@benjaminaubin benjaminaubin requested review from timudk and removed request for rromb and timudk July 25, 2023 16:41
ablattmann
ablattmann previously approved these changes Jul 25, 2023
@benjaminaubin benjaminaubin marked this pull request as ready for review July 26, 2023 08:31
@benjaminaubin benjaminaubin changed the title Pre release Pre release 1.0 Jul 26, 2023
@benjaminaubin benjaminaubin requested review from palp and removed request for timudk July 26, 2023 08:39
Copy link
Copy Markdown
Contributor

@palp palp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, passes tests on #57

@benjaminaubin benjaminaubin merged commit e596332 into main Jul 26, 2023
@benjaminaubin benjaminaubin deleted the pre-release-1.0 branch July 27, 2023 10:54
LinearFalcon pushed a commit to LinearFalcon/generative-models that referenced this pull request Jul 6, 2024
* clean requirements

* rm taming deps

* isort, black

* mv lipips, license

* clean vq, fix path

* fix loss path, gitignore

* tested requirements pt13

* fix numpy req for python3.8, add tests

* fix name

* fix dep scipy 3.8 pt2

* add black test formatter
SevanBrodjian pushed a commit to SevanBrodjian/sd-latent-exploration that referenced this pull request Aug 12, 2024
* clean requirements

* rm taming deps

* isort, black

* mv lipips, license

* clean vq, fix path

* fix loss path, gitignore

* tested requirements pt13

* fix numpy req for python3.8, add tests

* fix name

* fix dep scipy 3.8 pt2

* add black test formatter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants