Add shift_times to BaseSorting#4551
Open
h-mayorquin wants to merge 3 commits intoSpikeInterface:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BaseRecordinghasshift_times(#3509).BaseSortinggotget_start_time/get_end_timein #4525 but no way to shift the timing through the public API. This PR addsshift_timestoBaseSorting.shift_timeson a sorting never mutates the registered recording. After #4525,register_recordingcopies the recording's start time into each segment's_t_start, so_t_startrepresents the effective start time of the segment.shift_times(delta)addsdeltato_t_start. When a recording is registered, the effective shift relative to the recording is_t_start - recording.get_start_time(); this is 0 right after registration and becomes 5.0 aftershift_times(5.0).sample_index_to_time,time_to_sample_index,get_end_time, andget_timesnow compose this shift. I also updated theget_unit_spike_train_in_secondsnative path (used by NWB extractors) which previously ignored_t_start.