-
Notifications
You must be signed in to change notification settings - Fork 15
ext_algebra: let the Ext DGA carry a differential and compute cohomology #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JoeyBF
wants to merge
7
commits into
SpectralSequences:master
Choose a base branch
from
JoeyBF:claude/ext-algebra-cohomology
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ed9288d
ext_algebra: let the Ext DGA carry a differential and compute cohomology
claude d465c71
ext_algebra: cohomology_subquotient + the Adams d₂ as an ExtDifferential
claude 673d040
ext_algebra: route the secondary d₂/E₃ page onto the shared cohomolog…
claude 83ce2f2
ext_algebra: fix CI — adapt secondary_massey to the hom_k page-fn API…
claude 5678bd7
ext_algebra: match the e3_page convention at the top edge of the reso…
claude b80d4e9
ext_algebra: assert capped matrix dimensions before using their ranks
claude e904c9e
ext_algebra: reframe docs so ExtAlgebra reads as classical Ext(k,k)
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick win
Guard the
gens - rank_out - rank_incomputation against invariant violations.This subtraction implicitly assumes
rank_out + rank_in <= gens, which only holds if the differential satisfiesd ∘ d = 0atb. That's never checked, so a malformed or buggyExtDifferentialimpl would trigger ausizeunderflow — panicking in debug or silently wrapping to a huge value in release — instead of a clear error.🛡️ Proposed defensive check
let rank_out = d.matrix_capped(b, cap)?.row_reduce(); let rank_in = d .matrix_capped(source, cap) .map_or(0, |mut m| m.row_reduce()); + debug_assert!( + rank_out + rank_in <= gens, + "ExtDifferential violates d∘d=0 at {b:?}: rank_out={rank_out}, rank_in={rank_in}, gens={gens}" + ); Some(gens - rank_out - rank_in)📝 Committable suggestion
🤖 Prompt for AI Agents