Skip to content

chore: fallout work from bringing beagle back up to date with dawgs#105

Merged
zinic merged 1 commit into
SpecterOps:mainfrom
zinic:main
Jul 10, 2026
Merged

chore: fallout work from bringing beagle back up to date with dawgs#105
zinic merged 1 commit into
SpecterOps:mainfrom
zinic:main

Conversation

@zinic

@zinic zinic commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Description

This PR addresses Dawgs behavior gaps found while uplifting Beagle to Dawgs
mainline:

  • Filter projected triplestore edges when either endpoint node is deleted,
    including edge counts, full edge iteration, and adjacency iteration.
  • Preserve Neo4j relationship-kind predicates in the WHERE clause whenever
    they appear beneath a negation. Positive relationship-kind predicates can
    still be lifted into the relationship pattern, while simple and compound
    negations retain their original semantics.
  • Reject empty query/v2 relationship-kind and node-kind predicates during
    query construction instead of rendering invalid Cypher.
  • Add regression coverage for deleted projection endpoints, simple and compound
    negated relationship kinds, and empty kind collections.

Resolves: N/A (Beagle uplift follow-up)

Type of Change

  • Chore (a change that does not modify the application functionality)
  • Bug fix (a change that fixes an issue)
  • New feature / enhancement (a change that adds new functionality)
  • Refactor (no behaviour change)
  • Test coverage
  • Build / CI / tooling
  • Documentation

Testing

The complete unit and backend integration matrix passed with the race detector
enabled:

  • make test
  • make test_neo4j with the Neo4j CONNECTION_STRING
  • make test_pg with the PostgreSQL CONNECTION_STRING

Validation checklist:

  • Unit tests added / updated
  • Integration tests added / updated
  • Full test matrix run (unit, Neo4j, and PostgreSQL targets)

Screenshots (if appropriate):

N/A

Driver Impact

  • PostgreSQL driver (drivers/pg)
  • Neo4j driver (drivers/neo4j)

Checklist

  • Code is formatted
  • All existing tests pass
  • go.mod / go.sum are up to date if dependencies changed

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zinic, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 19 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c1e1fa29-894d-4976-90d0-9656fcd1e1b5

📥 Commits

Reviewing files that changed from the base of the PR and between baff269 and c413fd5.

📒 Files selected for processing (6)
  • container/triplestore.go
  • container/triplestore_test.go
  • query/neo4j/rewrite.go
  • query/v2/backend_test.go
  • query/v2/query.go
  • query/v2/query_test.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zinic zinic merged commit 7f871e7 into SpecterOps:main Jul 10, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant