Skip to content

Add make_atan binding #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dance858 merged 2 commits into from
Oct 7, 2026
Merged

Add make_atan binding #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ced79f
Add make_atan binding for the engine's new atan atom
dance858 Oct 7, 2026
c7ed891
Bump SparseDiffEngine to 1334e80 (atan atom, #131)
dance858 Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion SparseDiffEngine
Open in desktop
Submodule SparseDiffEngine updated 5 files
+1 −0 include/atoms/elementwise_full_dom.h
+38 −0 src/atoms/elementwise_full_dom/trig.c
+2 −0 tests/all_tests.c
+19 −0 tests/jacobian_tests/composite/test_chain_rule_jacobian.h
+20 −0 tests/wsum_hess/composite/test_chain_rule_wsum_hess.h
31 changes: 31 additions & 0 deletions sparsediffpy/_bindings/atoms/atan.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
#ifndef ATOM_ATAN_H
#define ATOM_ATAN_H

#include "common.h"
#include "elementwise_full_dom.h"

static PyObject *py_make_atan(PyObject *self, PyObject *args)
{
PyObject *child_capsule;
if (!PyArg_ParseTuple(args, "O", &child_capsule))
{
return NULL;
}
expr *child = (expr *) PyCapsule_GetPointer(child_capsule, EXPR_CAPSULE_NAME);
if (!child)
{
PyErr_SetString(PyExc_ValueError, "invalid child capsule");
return NULL;
}

expr *node = new_atan(child);
if (!node)
{
PyErr_SetString(PyExc_RuntimeError, "failed to create atan node");
return NULL;
}
expr_retain(node); /* Capsule owns a reference */
return PyCapsule_New(node, EXPR_CAPSULE_NAME, expr_capsule_destructor);
}

#endif /* ATOM_ATAN_H */
2 changes: 2 additions & 0 deletions sparsediffpy/_bindings/bindings.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
/* Include atom bindings */
#include "atoms/add.h"
#include "atoms/asinh.h"
#include "atoms/atan.h"
#include "atoms/atanh.h"
#include "atoms/broadcast.h"
#include "atoms/convolve.h"
Expand Down Expand Up @@ -119,6 +120,7 @@ static PyMethodDef DNLPMethods[] = {
{"make_sinh", py_make_sinh, METH_VARARGS, "Create sinh node"},
{"make_tanh", py_make_tanh, METH_VARARGS, "Create tanh node"},
{"make_asinh", py_make_asinh, METH_VARARGS, "Create asinh node"},
{"make_atan", py_make_atan, METH_VARARGS, "Create atan node"},
{"make_atanh", py_make_atanh, METH_VARARGS, "Create atanh node"},
{"make_upper_tri", py_make_upper_tri, METH_VARARGS, "Create upper_tri node"},
{"make_broadcast", py_make_broadcast, METH_VARARGS, "Create broadcast node"},
Expand Down
Loading