Repository navigation
Include matrix_sum.h for the sum dispatchers; pin sparsediff_linalg 0902e29 - #158
Merged
Merged
Conversation
…902e29 Library PR #17 moved sum_matrices_*, sum_scaled_matrices_fill_values and sum_4_matrices_* from matmul.h to matrix_sum.h. add.c and the elementwise common.c use only sums and switch headers; quad_over_lin, quad_form, multiply and matmul use both and add the include. The pin (library main, 0902e29) also brings #18 (csr_csc_matmul_* private; the engine no longer calls them since #157) and #19 (sum_n_matrices_*). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sparsediff_linalgto library main (0902e29), which brings in:sum_matrices_*,sum_scaled_matrices_fill_valuesandsum_4_matrices_*move frommatmul.hto the newmatrix_sum.h.csr_csc_matmul_*become private. The engine stopped calling them in Route convolve's Jacobian through the BA_matrices dispatchers #157.sum_n_matrices_*. Nothing uses them yet; the hstack PR stacked on this one will.matrix_sum.hinclude where the sums are used.add.candelementwise_full_dom/common.cuse only sums, so they swapmatmul.hformatrix_sum.h.quad_over_lin.c,quad_form.c,multiply.candmatmul.cuse both headers and add the include.Testing
git grep csr_csc_matmulfinds nothing insrc,includeortests.🤖 Generated with Claude Code