Repository navigation
Conda forge blas - #129
Merged
Merged
Conda forge blas#129
Conversation
- MSVC: use the OpenBLAS::OpenBLAS target when a config provides it (vcpkg), otherwise fall back to finding openblas.lib and cblas.h directly, as conda-forge's openblas ships no CMake config. - Unix: link libcblas when it sits next to the BLAS FindBLAS picked, ahead of BLAS itself. conda-forge splits CBLAS into libcblas; linking it explicitly keeps the package working when users switch BLAS implementations. - Add SDE_WARNINGS_AS_ERRORS (default ON standalone, OFF under scikit-build) to gate MSVC /WX. Closes #126. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Builds and tests the engine on Linux and Windows against conda-forge's BLAS packages (no OpenBLAS CMake config on Windows, split libcblas on Linux). On Linux it also checks libcblas is a direct dependency and re-runs the tests after switching to the netlib BLAS variant. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
setup-micromamba failed after creating the environment; Miniforge via setup-miniconda is the common setup for conda-forge-based CI. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
conda-forge's global pinning builds against the netlib libblas/libcblas, which carry the switchable libblas.so.3/libcblas.so.3 SONAMEs; the openblas variant is a symlink to libopenblas.so.0, so linking against it records that instead. Mirror the pinning and test the switch the other way round. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #126. With this change, the conda-forge recipe (conda-forge/staged-recipes#34978) can drop 0001-use-conda-forge-blas.patch once a sparsediffpy release ships with it.
Changes (CMakeLists.txt)
Unchanged
Testing
🤖 Generated with Claude Code