chore(hooks): unify helpers as _helpers.sh and block Linear refs in commit-msg#273
Closed
John-David Dalton (jdalton) wants to merge 1 commit intomainfrom
Closed
chore(hooks): unify helpers as _helpers.sh and block Linear refs in commit-msg#273John-David Dalton (jdalton) wants to merge 1 commit intomainfrom
John-David Dalton (jdalton) wants to merge 1 commit intomainfrom
Conversation
…ommit-msg Rename _api-key-check.sh to _helpers.sh for fleet consistency. Add a commit-msg check that rejects messages containing Linear issue IDs (any of 27 Socket workspace team keys) or linear.app/... URLs — Linear tracking belongs in Linear, not the commit history.
Collaborator
Author
|
Converting to branch-only push per repo owner — branch stays available, no PR needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.git-hooks/_api-key-check.sh→.git-hooks/_helpers.shfor fleet consistency.commit-msg: rejects messages containing<TEAM>-<N>for any of the 27 Socket Linear team keys, orlinear.app/...URLs. Git comment lines ignored.Why
Test plan
bash .git-hooks/commit-msg <msg with ENG-1234>exits 1.UTF-8,SHA-256,CVE-2024-1234do not trigger (no false positives).