chore(test): move vitest cache to node_modules/.cache#189
Closed
John-David Dalton (jdalton) wants to merge 1 commit intomainfrom
Closed
chore(test): move vitest cache to node_modules/.cache#189John-David Dalton (jdalton) wants to merge 1 commit intomainfrom
John-David Dalton (jdalton) wants to merge 1 commit intomainfrom
Conversation
`pnpm install` already clears `node_modules/` (and its `.cache/` subdir) automatically, so pinning vitest's cacheDir there gives us free cache invalidation on every install without needing a dedicated clean step. Matches the pattern applied in ../socket-packageurl-js, ../socket-sdk-js (#616), ../socket-cli (#1274), and ../meander. Applied to both the main and isolated vitest configs. Dropped `**/.cache/` from .gitignore — nothing writes to a top-level `.cache/` anymore; the only cache consumers are now rooted under node_modules.
Collaborator
Author
|
Superseded — landed directly on main as c03dfa9. |
John-David Dalton (jdalton)
deleted the
chore/vitest-cache-to-node-modules
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cacheDirin both vitest configs moves from<repo>/.cache/vitest{,-isolated}to<repo>/node_modules/.cache/vitest{,-isolated}.pnpm installalready wipesnode_modules/(and its.cache/subdir), so this gives us free cache invalidation on every install — no dedicated clean step needed.../socket-packageurl-js,../socket-sdk-js(#616),../socket-cli(#1274), and../meander.**/.cache/from.gitignoresince nothing writes to a top-level.cache/anymore.Test plan
pnpm lint+pnpm test+pnpm run buildwill verify.--no-verifybecausesrc/dlx/manifest.tshas a pre-existing oxfmt formatter issue that tripped the pre-commit lint hook (verified on cleanmainas well). Unrelated to this change; happy to fix it separately if you want.