Repository navigation
Support multi-endpoint window covering - #3191
HunsupJung wants to merge 2 commits into
Conversation
|
Invitation URL: |
Test Results 73 files 544 suites 0s ⏱️ Results for commit 87da271. ♻️ This comment has been updated with latest results. |
|
matter-window-covering_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against 87da271 |
e7b42a3 to
04ec853
Compare
04ec853 to
e2d4adc
Compare
Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>
e2d4adc to
fa58718
Compare
|
Hi @HunsupJung , Before reviewing, can you please provide:
Thanks! |
| if #wc_cluster_eps > 1 then | ||
| create_or_update_multi_devices(driver, device, wc_cluster_eps) | ||
| else |
There was a problem hiding this comment.
This section will make a multi-ep device skip the battery checks in the main do_configure pathing. I think we should ensure there is still always 1 battery check (as there is now), and that these should be integrated to make that check continue to always occur.
There was a problem hiding this comment.
So for Endpoint 1, you’re suggesting we go with a battery check — is that right?
By the way, could you share what the testing criteria should be? Since there’s no defined test checklist, it’s always a bit unclear what standard to go by when I share test results. |
|
@hcarter-775 |
Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>
67e3370 to
87da271
Compare
Type of Change
Checklist
Description of Change
https://smartthings.atlassian.net/wiki/spaces/STHK/pages/5632132591/Matter+Wintec+Blind+-+Support+Direction
Summary of Completed Tests
https://smartthings.atlassian.net/wiki/spaces/STHK/pages/5913215186/Matter+Wintec+Blind+-+Test+Result