Skip to content

Support multi-endpoint window covering - #3191

Open
HunsupJung wants to merge 2 commits into
mainfrom
feature/multi-endpoint-window-covering
Open

HunsupJung wants to merge 2 commits into
mainfrom
feature/multi-endpoint-window-covering

Conversation

@HunsupJung

@HunsupJung HunsupJung commented Aug 21, 2026 •

Copy link
Copy Markdown
Collaborator

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

https://smartthings.atlassian.net/wiki/spaces/STHK/pages/5632132591/Matter+Wintec+Blind+-+Support+Direction

Summary of Completed Tests

https://smartthings.atlassian.net/wiki/spaces/STHK/pages/5913215186/Matter+Wintec+Blind+-+Test+Result

@github-actions

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Aug 21, 2026 •

Copy link
Copy Markdown

Test Results

   73 files    544 suites   0s ⏱️
3 304 tests 3 304 ✅ 0 💤 0 ❌
5 297 runs  5 297 ✅ 0 💤 0 ❌

Results for commit 87da271.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Aug 21, 2026 •

Copy link
Copy Markdown

matter-window-covering_coverage.xml

File Coverage
All files 87% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-window-covering/src/sub_drivers/closure/closure_handlers/capability_handlers.lua 73% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-window-covering/src/sub_drivers/closure/closure_handlers/attribute_handlers.lua 86% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-window-covering/src/lazy_load_subdriver.lua 57% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-window-covering/src/init.lua 88% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-window-covering/src/sub_drivers/closure/closure_utils/utils.lua 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-window-covering/src/sub_drivers/closure/init.lua 78% ❌

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 87da271

@HunsupJung
HunsupJung force-pushed the feature/multi-endpoint-window-covering branch 2 times, most recently from e7b42a3 to 04ec853 Compare August 21, 2026 07:20
@HunsupJung
HunsupJung force-pushed the feature/multi-endpoint-window-covering branch from 04ec853 to e2d4adc Compare August 28, 2026 10:30
Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>
@HunsupJung
HunsupJung force-pushed the feature/multi-endpoint-window-covering branch from e2d4adc to fa58718 Compare September 7, 2026 06:34
@hcarter-775

Copy link
Copy Markdown
Contributor

Hi @HunsupJung ,

Before reviewing, can you please provide:

  1. A complete description of the changes
  2. A review of your testing procedure?

Thanks!

Comment on lines +278 to 280
if #wc_cluster_eps > 1 then
create_or_update_multi_devices(driver, device, wc_cluster_eps)
else

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section will make a multi-ep device skip the battery checks in the main do_configure pathing. I think we should ensure there is still always 1 battery check (as there is now), and that these should be integrated to make that check continue to always occur.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So for Endpoint 1, you’re suggesting we go with a battery check — is that right?

@HunsupJung

Copy link
Copy Markdown
Collaborator Author

@hcarter-775

  1. A review of your testing procedure?

By the way, could you share what the testing criteria should be? Since there’s no defined test checklist, it’s always a bit unclear what standard to go by when I share test results.

@HunsupJung

Copy link
Copy Markdown
Collaborator Author

@hcarter-775
I’ve removed a lot of the unnecessary parts. Could you take another look?

Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>
@HunsupJung
HunsupJung force-pushed the feature/multi-endpoint-window-covering branch from 67e3370 to 87da271 Compare October 19, 2026 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants