Matter Switch: Register setColorTemperature native handler#2988
Open
hcarter-775 wants to merge 2 commits into
Open
Matter Switch: Register setColorTemperature native handler#2988hcarter-775 wants to merge 2 commits into
hcarter-775 wants to merge 2 commits into
Conversation
hcarter-775
requested review from
aleclorimer,
cjswedes,
ctowns,
nickolas-deboom and
tpmanley
|
Invitation URL: |
Test Results 72 files ±0 511 suites ±0 0s ⏱️ ±0s Results for commit 87da728. ± Comparison against base commit a80ea6f. This pull request removes 2 tests.♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 87da728 |
hcarter-775
force-pushed
the
support/set-color-temperature-native-handler
branch
from
03e96de to
87da728
Compare
cjswedes
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
We currently only attempt native handler registration in the default handler for the setColorTemperature -> Matter command. This means that no devices actually using the Matter Switch driver will use this native handler.
I also renamed the variable, since mostRecentTemp is 1. pretty inaccurate for what's actually going on, and 2. is very unclear.
I also de-persisted the variable to match the default handler, and therefore the native handler expectations. Since this is only used to store command state, we have no need to persist this.
Summary of Completed Tests
This native handler has been in production for a while, so testing is fairly sufficient. This just adds the actual registration.
Some unit tests updated, and while checking the failing tests I removed a couple effectively duplicate tests, as a part of the general cleanup work I've been doing to not duplicate tests, for more effective development moving forward. To "extra" prove these tests were repetitions, the luacov analyzer didn't notice any drop in testing coverage.