Conversation
…ivers Remove apiv6 subdrivers
The check_duplicates.py script was failing when a PR deleted a profile file. The script would try to open the deleted file for comparison, causing a FileNotFoundError. This fix adds an existence check before attempting to open the file, skipping deleted files with an informative message.
…for-deleted-profile-files Fix duplicate profile check to handle deleted files
These are based on what I have setup for myself locally, but are not exactly the same, so are somewhat untested. Some of the skills and potentially even the AGENTS.md file may be too large for very small models, but I think this will really help anyone using tools like opencode, claude code, codex, etc when working with agents in this repo.
Add AGENTS.md and a set of skills to help agents in this repository
* WWSTCERT-11638 Govee Floor Lamp 3 * Apply suggestion from @ctowns Co-authored-by: Cooper Towns <cooper.towns@smartthings.com> --------- Co-authored-by: Cooper Towns <cooper.towns@smartthings.com>
…ton. (#2510) * Add Sonoff SNZB-01M Smart Scene Button into zigbee-button. * modify Copyright Date * modify test_sonoff.py fix PR error * Update copyright year from 2022 to 2026,remove remove whitespace-only lines Update copyright year from 2022 to 2026,remove remove whitespace-only lines * remove log.info remove log.info * Use defaults for Sonoff battery and added lifecycle - Remove custom battery attribute handler and added lifecycle in Sonoff subdriver - Align Sonoff tests with default added behavior and keep battery report coverage * remove log * Fix Sonoff multi-button sub-driver registration and test execution * update copyright sections for sonoff multi-button * fix: address review feedback for Sonoff SNZB-01M button support - Reuse existing four-buttons-battery profile instead of custom sonoff-buttons-battery - Mirror button events to main component via emit_event for device list visibility - Update test profile reference and add main component event assertions - Remove unused sonoff-buttons-battery.yml profile * fix: resolve Sonoff SNZB-01M unit test failures - replace unsupported build_custom_report_attribute usage with an explicit custom Zigbee attribute report builder - add missing main component expectations for the added lifecycle test - add min_api_version guards to Sonoff test cases - keep Sonoff button event assertions aligned with the four-buttons-battery profile behavior * Removed the SONOFF entry from the generic supported values table and moved its button metadata initialization into the SONOFF sub-driver. * Apply suggestion from @KKlimczukS Co-authored-by: Konrad K <33450498+KKlimczukS@users.noreply.github.com> * Apply suggestion from @KKlimczukS Co-authored-by: Konrad K <33450498+KKlimczukS@users.noreply.github.com> * Apply suggestion from @KKlimczukS Co-authored-by: Konrad K <33450498+KKlimczukS@users.noreply.github.com> * Apply suggestion from @KKlimczukS Co-authored-by: Konrad K <33450498+KKlimczukS@users.noreply.github.com> --------- Co-authored-by: Konrad K <33450498+KKlimczukS@users.noreply.github.com>
…-sensitivity Fix handling for cameras without per-zone sensitivity handling
ctowns
requested review from
aleclorimer,
cjswedes,
hcarter-775,
nickolas-deboom,
tpmanley and
z-michel
Test Results 72 files 511 suites 0s ⏱️ Results for commit a80ea6f. ♻️ This comment has been updated with latest results. |
|
matter-lock_coverage.xml
matter-rvc_coverage.xml
matter-sensor_coverage.xml
matter-switch_coverage.xml
zigbee-button_coverage.xml
zwave-button_coverage.xml
zwave-lock_coverage.xml
zwave-sensor_coverage.xml
zwave-siren_coverage.xml
zwave-smoke-alarm_coverage.xml
zwave-thermostat_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against a80ea6f |
hcarter-775
approved these changes
May 20, 2026
cjswedes
approved these changes
May 20, 2026
aleclorimer
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.