Skip to content

WWSTCERT-11699 Z-Wave Scene Control Switch#2977

Open
cbaumler wants to merge 3 commits into
mainfrom
new_device/WWSTCERT-11699
Open

WWSTCERT-11699 Z-Wave Scene Control Switch#2977
cbaumler wants to merge 3 commits into
mainfrom
new_device/WWSTCERT-11699

Conversation

@cbaumler
Copy link
Copy Markdown
Contributor

Relevant WWST tickets:

  • WWSTCERT-11699

@github-actions
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 18, 2026

Test Results

   72 files    511 suites   0s ⏱️
2 867 tests 2 867 ✅ 0 💤 0 ❌
4 740 runs  4 740 ✅ 0 💤 0 ❌

Results for commit adb5fe7.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 18, 2026

File Coverage
All files 98%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-button/src/zwave-multi-button/shelly_wave_i4/can_handle.lua 83%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-button/src/lazy_load_subdriver.lua 57%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against adb5fe7

Copy link
Copy Markdown
Contributor

@aleclorimer aleclorimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see we have some other ids that are hex strings of the manufacturer id, product type, and product id, but this id field is in base 10. Not sure if that matters.

@cbaumler
Copy link
Copy Markdown
Contributor Author

I see we have some other ids that are hex strings of the manufacturer id, product type, and product id, but this id field is in base 10. Not sure if that matters.

I don't think it should matter as long as the id is unique. @cjswedes what do you think?

@cjswedes
Copy link
Copy Markdown
Contributor

I see we have some other ids that are hex strings of the manufacturer id, product type, and product id, but this id field is in base 10. Not sure if that matters.

I don't think it should matter as long as the id is unique. @cjswedes what do you think?

I dont think it matters technically, but we should probably change it to match our existing convention of using hex.

@nand-nor
Copy link
Copy Markdown
Contributor

I see we have some other ids that are hex strings of the manufacturer id, product type, and product id, but this id field is in base 10. Not sure if that matters.

I don't think it should matter as long as the id is unique. @cjswedes what do you think?

I dont think it matters technically, but we should probably change it to match our existing convention of using hex.

Agree, especially to avoid confusion since for example 11 in hex and 11 in decimal are different values so it should all be consistently either base 10 or base 16. Especially if these values ever need to be parsed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants