WWSTCERT-11699 Z-Wave Scene Control Switch

[cbaumler]

Relevant WWST tickets:

• WWSTCERT-11699

[github-actions]

Invitation URL:
https://bestow-regional.api.smartthings.com/invite/RPMxro8D77lm

[github-actions]

Test Results

   72 files    511 suites   0s ⏱️
2 867 tests 2 867 ✅ 0 💤 0 ❌
4 740 runs  4 740 ✅ 0 💤 0 ❌

Results for commit adb5fe7.

♻️ This comment has been updated with latest results.

[github-actions]

File	Coverage
All files	98%	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-button/src/zwave-multi-button/shelly_wave_i4/can_handle.lua	83%	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-button/src/lazy_load_subdriver.lua	57%	❌

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against adb5fe7

[aleclorimer]

I see we have some other ids that are hex strings of the manufacturer id, product type, and product id, but this id field is in base 10. Not sure if that matters.

[cbaumler]

I see we have some other ids that are hex strings of the manufacturer id, product type, and product id, but this id field is in base 10. Not sure if that matters.

I don't think it should matter as long as the id is unique. @cjswedes what do you think?

[cjswedes]

I see we have some other ids that are hex strings of the manufacturer id, product type, and product id, but this id field is in base 10. Not sure if that matters.

I don't think it should matter as long as the id is unique. @cjswedes what do you think?

I dont think it matters technically, but we should probably change it to match our existing convention of using hex.

[nand-nor]

I see we have some other ids that are hex strings of the manufacturer id, product type, and product id, but this id field is in base 10. Not sure if that matters.

I don't think it should matter as long as the id is unique. @cjswedes what do you think?

I dont think it matters technically, but we should probably change it to match our existing convention of using hex.

Agree, especially to avoid confusion since for example 11 in hex and 11 in decimal are different values so it should all be consistently either base 10 or base 16. Especially if these values ever need to be parsed