Skip to content

add firstled-io_M4S4BAC#2971

Open
thinkaName wants to merge 1 commit into
SmartThingsCommunity:mainfrom
thinkaName:firstled-io_M4S4BAC
Open

add firstled-io_M4S4BAC#2971
thinkaName wants to merge 1 commit into
SmartThingsCommunity:mainfrom
thinkaName:firstled-io_M4S4BAC

Conversation

@thinkaName
Copy link
Copy Markdown
Contributor

@thinkaName thinkaName commented May 14, 2026 •
edited
Loading

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 14, 2026 •
edited
Loading

Duplicate profile check: Passed - no duplicate profiles detected.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 14, 2026

Invitation URL:
https://bestow-regional.api.smartthings.com/invite/5z2R5p3OzzM1

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 14, 2026 •
edited
Loading

Test Results

   72 files    511 suites   0s ⏱️
2 874 tests 2 874 ✅ 0 💤 0 ❌
4 760 runs  4 760 ✅ 0 💤 0 ❌

Results for commit 29ea878.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 14, 2026 •
edited
Loading

File Coverage
All files 95% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/frient-IO/init.lua 88% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/frient-IO/unbind_request.lua 71% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/preferences.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/init.lua 92% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/lazy_load_subdriver.lua 57% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/frient/init.lua 94% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/tuya-multi/can_handle.lua 90% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/firstled-io/init.lua 64% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/configurations/init.lua 98% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/inovelli/init.lua 98% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/laisiao/init.lua 96% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/aqara-light/init.lua 92% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/aqara/version/init.lua 94% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/aqara/init.lua 94% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/color_temp_range_handlers/init.lua 71% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/inovelli/vzm30-sn/init.lua 95% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/inovelli/vzm32-sn/init.lua 95% ✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 29ea878

@thinkaName thinkaName force-pushed the firstled-io_M4S4BAC branch 2 times, most recently from d0d3e68 to 09fa419 Compare May 18, 2026 05:48
cjswedes
cjswedes reviewed May 18, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cjswedes cjswedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures will need to be resolved prior to merging.

Comment thread drivers/SmartThings/zigbee-switch/src/test/test_firstled_switch.lua Outdated
Comment thread drivers/SmartThings/zigbee-switch/src/firstled-io/init.lua
Comment thread drivers/SmartThings/zigbee-switch/src/firstled-io/init.lua Outdated
Comment thread drivers/SmartThings/zigbee-switch/src/firstled-io/init.lua Outdated
{ visibility = { displayed = false } }))

device:send(cluster_base.write_manufacturer_specific_attribute(device,
PRIVATE_CLUSTER_ID, PRIVATE_ATTRIBUTE_ID, MFG_CODE, data_types.Uint8, 0x01)) -- private
Copy link
Copy Markdown
Contributor

@cjswedes cjswedes May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont really know what this attribute write does, but is it something that should be done in device init? The difference being it would be written anytime the hub restarts or the driver is updated

Copy link
Copy Markdown
Contributor

@cjswedes cjswedes May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this was moved to infoChanged to handle preference changes. It seems like it might still be needed in the added handler so that the initial preference default value is written.

Copy link
Copy Markdown
Contributor Author

@thinkaName thinkaName May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the device is entering the pairing process, it will restore the data to the default values, and both ends will have the same default values.

@thinkaName thinkaName force-pushed the firstled-io_M4S4BAC branch from 09fa419 to 2b92e15 Compare May 19, 2026 08:25
@thinkaName thinkaName force-pushed the firstled-io_M4S4BAC branch from 2b92e15 to 29ea878 Compare May 19, 2026 08:58
@nand-nor
Copy link
Copy Markdown
Contributor

nand-nor commented May 20, 2026

Can code coverage be improved in firstled-io/init.lua? Device init tests, preference changes, scenes cluster handling, profile switching, that kind of thing

nand-nor
nand-nor reviewed May 20, 2026
View reviewed changes
Comment thread drivers/SmartThings/zigbee-switch/src/firstled-io/init.lua
-- Create Button if necessary
local button_amount = get_button_amount(device)
if button_amount >= 1 then
for i = children_amount+1,children_amount + button_amount, 1 do
Copy link
Copy Markdown
Contributor

@nand-nor nand-nor May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for i = children_amount+1,children_amount + button_amount, 1 do
for i = children_amount + 1, children_amount + button_amount, 1 do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjswedes cjswedes cjswedes left review comments

@nand-nor nand-nor nand-nor left review comments

@aleclorimer aleclorimer Awaiting requested review from aleclorimer

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thinkaName @nand-nor @cjswedes